Skip to content

Conversation

tangdf
Copy link

@tangdf tangdf commented Jan 16, 2018

The DynamicInvoke method of MulticastDelegate is too poor.

https://github.com/tangdf/EntityFramework.DynamicFilters/blob/7ed94eb3a45ff141f0c7ea8fbec9a405e53ca2f2/src/DelegateBenchmark/DelegateInvoking.cs#L10-L40

Benchmark results:

Method Mean Error StdDev
MulticastDelegate_DynamicInvoke 528.562 ns 2.5630 ns 2.3974 ns
FunDelegate_Invoke 3.573 ns 0.0227 ns 0.0202 ns

@JonathanMagnan JonathanMagnan self-assigned this Jan 16, 2018
@JonathanMagnan
Copy link
Member

Hello @tangdf ,

Thank you for reporting, we will look at it.

I'm not sure yet how we will handle this change since we want to stay backward compatible. We might support both (your solution and the MulticastDelegate)

Best Regards,

Jonathan


Help us to support this library: Donate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants