Skip to content

feat: SpineRuntimeObject: Disable updateHitboxes to avoid unnecessary recomputation #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

feat: SpineRuntimeObject: Disable updateHitboxes to avoid unnecessary recomputation #7834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d05b16
disable updateHitboxes for SpineRuntimeObject
danvervlad Sep 16, 2025
1cc56eb
add static isHitBoxesUpdateDisabled for SpineRuntimeObject
danvervlad Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Extensions/Spine/spineruntimeobject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ namespace gdjs {

readonly spineResourceName: string;

static isHitBoxesUpdateDisabled = false;

/**
* @param instanceContainer The container the object belongs to.
* @param objectData The object data used to initialize the object
Expand All @@ -74,6 +76,10 @@ namespace gdjs {
this.setAnimationIndex(0);
this._renderer.updateAnimation(0);

if (SpineRuntimeObject.isHitBoxesUpdateDisabled) {
this.hitBoxes.length = 0;
}

// *ALWAYS* call `this.onCreated()` at the very end of your object constructor.
this.onCreated();
}
Expand Down Expand Up @@ -183,6 +189,14 @@ namespace gdjs {
}
}

updateHitBoxes(): void {
if (SpineRuntimeObject.isHitBoxesUpdateDisabled) {
return;
}

super.updateHitBoxes();
}

extraInitializationFromInitialInstance(
initialInstanceData: InstanceData
): void {
Expand Down