-
Notifications
You must be signed in to change notification settings - Fork 61
Clear All Data Button [AARD-2059]
#1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Zach Rutman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, otherwise everything looks good. I will open a PR to fix the typing issues with the UI provider, so please wait for that to be merged and then you will be able to remove onConfirm
and onCancel
from the custom props.
EDIT: I also think this confirm modal could use a bit more thought - what happens if someone is doing something in a modal that we want to confirm? Opening the confirm modal would close their modal and they would lose their progress. I suppose there could be custom logic per panel passed through the onConfirm
or onCancel
callbacks, so if that's the solution I would like to see a demo showing that it will work the way we want it to. Also, maybe onCancel
should open the parent by default?
…ismatch' into alexey/2059/clear-all-data-button
…m/Autodesk/synthesis into alexey/2059/clear-all-data-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Task
Create a button that deletes all stored data.
AARD-2059
Symptom
When adding/testing new features, there were scenarios where I have wanted to clear all stored data, but there was no easy way to do that. (I have to go into chrome settings, clear data, etc.)
Solution
Add a button in debug tools that clears all saved data (not just preferences). A Conformation Modal was also added to make sure that the button is not accidently pressed.
Verification
Pressing clear all data spawns a modal asking for confirmation. Clicking accept removes all preferences and cached robots. Clicking cancel closes the modal and all the data is still there.
Before merging, ensure the following criteria are met: