Skip to content

Clear All Data Button [AARD-2059] #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 13, 2025
Merged

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Aug 8, 2025

Task

Create a button that deletes all stored data.

AARD-2059

Symptom

When adding/testing new features, there were scenarios where I have wanted to clear all stored data, but there was no easy way to do that. (I have to go into chrome settings, clear data, etc.)

Solution

Add a button in debug tools that clears all saved data (not just preferences). A Conformation Modal was also added to make sure that the button is not accidently pressed.

Verification

Pressing clear all data spawns a modal asking for confirmation. Clicking accept removes all preferences and cached robots. Clicking cancel closes the modal and all the data is still there.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 8, 2025
@AlexD717 AlexD717 added the ui/ux Relating to user interface, or in general, user experience label Aug 8, 2025
@AlexD717 AlexD717 requested review from a team as code owners August 8, 2025 16:00
Co-authored-by: Zach Rutman <[email protected]>
@AlexD717 AlexD717 requested a review from rutmanz August 8, 2025 22:28
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, otherwise everything looks good. I will open a PR to fix the typing issues with the UI provider, so please wait for that to be merged and then you will be able to remove onConfirm and onCancel from the custom props.

EDIT: I also think this confirm modal could use a bit more thought - what happens if someone is doing something in a modal that we want to confirm? Opening the confirm modal would close their modal and they would lose their progress. I suppose there could be custom logic per panel passed through the onConfirm or onCancel callbacks, so if that's the solution I would like to see a demo showing that it will work the way we want it to. Also, maybe onCancel should open the parent by default?

@AlexD717 AlexD717 requested a review from PepperLola August 13, 2025 23:27
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PepperLola PepperLola merged commit 9f84185 into dev Aug 13, 2025
16 checks passed
@PepperLola PepperLola deleted the alexey/2059/clear-all-data-button branch August 13, 2025 23:36
@PepperLola PepperLola mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants