Skip to content

Conversation

xavier-lc
Copy link
Contributor

@xavier-lc xavier-lc commented Jul 4, 2025

Fixes DOTSUP-36

Proposed changes:

  • The upsells on the Theme and Plugin File editor, permalinks, and Set Privacy Policy pages all have learn more links that open in a new tab. Fix that so they open inside the Help Center.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Run the command mentioned on the github-actions comment to enabvle this branch on your sandbox
  • On a simple site, go to /wp-admin/tools.php?page=theme-editor
  • Click on Learn more
  • Check that the Help Center app is opened:

image

  • Repeat the same steps on /wp-admin/tools.php?page=plugin-editor, /wp-admin/options-general.php?page=options-permalink, and /wp-admin/options-general.php?page=options-privacy

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the DOTSUP-36 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin DOTSUP-36

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented Jul 4, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/help-center/class-help-center.php 0/243 (0.00%) 0.00% 7 💔

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@rcrdortiz
Copy link
Contributor

Hey @xavier-lc, this PR is missing a description and testing instructions. My guess is that it's not ready for review, but this issue appeared in the RfR column on our board.

@xavier-lc xavier-lc added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Jul 7, 2025
@xavier-lc xavier-lc changed the title [WiP] Open support links on the upsell wrapper inside the Help Center Open support links on the upsell wrapper inside the Help Center Jul 7, 2025
@xavier-lc xavier-lc requested a review from a team July 7, 2025 16:28
@xavier-lc
Copy link
Contributor Author

My guess is that it's not ready for review, but this issue appeared in the RfR column on our board.

Yup, Linear marked it as in review it because of the branch name 🫠

dsas
dsas previously approved these changes Jul 8, 2025

const handleClick = event => {
event.preventDefault();
setShowSupportDoc( event.target.href );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: event.currentTarget would be more robust than event.target in case the upsell adds an inner element or whatever, but it works fine as it is.

@xavier-lc xavier-lc merged commit b4f1f8f into trunk Jul 8, 2025
66 of 67 checks passed
@xavier-lc xavier-lc deleted the DOTSUP-36 branch July 8, 2025 15:39
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 8, 2025
xavier-lc added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [mu wpcom Feature] Help Center [Package] Jetpack mu wpcom WordPress.com Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants