-
Notifications
You must be signed in to change notification settings - Fork 826
Open support links on the upsell wrapper inside the Help Center #44199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
projects/packages/jetpack-mu-wpcom/src/features/help-center/js/upsell-support-link-handler.js
Fixed
Show fixed
Hide fixed
Code Coverage SummaryCoverage changed in 1 file.
Coverage check overridden by
I don't care about code coverage for this PR
|
Hey @xavier-lc, this PR is missing a description and testing instructions. My guess is that it's not ready for review, but this issue appeared in the RfR column on our board. |
Yup, Linear marked it as in review it because of the branch name 🫠 |
|
||
const handleClick = event => { | ||
event.preventDefault(); | ||
setShowSupportDoc( event.target.href ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit: event.currentTarget
would be more robust than event.target
in case the upsell adds an inner element or whatever, but it works fine as it is.
Fixes DOTSUP-36
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/wp-admin/tools.php?page=theme-editor
Learn more
/wp-admin/tools.php?page=plugin-editor
,/wp-admin/options-general.php?page=options-permalink
, and/wp-admin/options-general.php?page=options-privacy