Move optional de/serializers for base64 bytes to base64::option #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
Resolves Azure#3213, making `base64` congruent with `time`.
heaths
requested review from
a team,
LarryOsterman,
RickWinter,
jalauzon-msft,
ronniegeraghty and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
Moves optional base64 (de)serializer helpers into a dedicated base64::option module so the root base64 module now targets non-optional fields (matching the time module pattern).
- Adds non-optional serialize/deserialize (standard and URL-safe) helpers to base64.
- Introduces base64::option module and updates examples/usages in code and benches.
- Updates changelogs and spell checker dictionary to reflect the breaking change.
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/typespec_client_core/src/base64.rs | Adds non-optional helpers and new option module; updates doc examples accordingly. |
| sdk/core/typespec_client_core/CHANGELOG.md | Documents the breaking change in base64 API. |
| sdk/core/azure_core/benches/deserialization.rs | Updates benchmark model attributes to use new option helpers. |
| sdk/core/azure_core/CHANGELOG.md | Mirrors breaking change notice for azure_core consumers. |
| .vscode/cspell.json | Adds deserializers to accepted words (changelog/docs). |
LarryOsterman
approved these changes
Oct 16, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Azure SDK for Key Vault
heaths
added a commit
to heaths/azure-sdk-for-rust
that referenced
this pull request
Oct 17, 2025
Based on feedback from Azure#3214
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3213, making
base64congruent withtime.