Model instancing #12528
Closed
Model instancing #12528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @lukemckinstry! ✅ We can confirm we have a CLA on file for you. |
lukemckinstry
force-pushed
the
model-instancing
branch
from
ce14a75 to
b8a24da
Compare
|
Closing in favor of #12588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Early draft PR with a simple prototype of static instancing. The approach here so far was to add an instances field to Model.fromGltfAsync() which accepts an array of modelMatrices. The implementation makes use of the existing classes used to support instancing from glTF with the
ext_mesh_gpu_instancingextension and i3dm. The prototype is limited to static instancing (which is what the classes behind the current glTF and i3dm instancing support) and does not get into dynamic instancing.Sandcastle
Issue number and link
#10846
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change