Skip to content

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Sep 2, 2025

Description

This is it, the big one, the big merge! 😄

This branch has acted as a staging/feature branch for the new rebuild of sandcastle. All the code changes have been reviewed independently in the PRs below. This PR is just to formalize the merge into main for the next release

Issue number and link

All of this work has been tracked in #12566

Testing plan

Make sure the new sandcastle is working as we'd expect!

  • Run npm run dev from the sandcastle package or npm run build-sandcastle and npm start from the project root

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz September 2, 2025 17:20
@jjspace jjspace self-assigned this Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjspace
Copy link
Contributor Author

jjspace commented Sep 2, 2025

#12854 has been merged 🎉

I also merged in main and converted the new Mars sandcastle from #12828

I believe this should be good to go once the other content updates from @ggetz are in

@ggetz
Copy link
Contributor

ggetz commented Sep 2, 2025

This should be ready to go! I'll merge once CI passes.

@ggetz
Copy link
Contributor

ggetz commented Sep 3, 2025

Release test failure is our good ol' friend "verify statistics". Unrelated to this PR.

@ggetz ggetz enabled auto-merge September 3, 2025 00:21
@ggetz ggetz added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 4186da8 Sep 3, 2025
8 of 9 checks passed
@ggetz ggetz deleted the sandcastle-v2 branch September 3, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants