Sandcastle metadata cleanup #12865
Sandcastle metadata cleanup #12865
Conversation
|
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
|
@jjspace I think we're missing a Gaussian splat example, plus updates to the existing gaussian splat example. Could you double check to make sure those changes are brought over correctly? |
| @@ -1,7 +1,6 @@ | |||
| legacyId: 3D Tiles Clipping Planes.html | |||
| title: 3D Tiles Clipping Planes | |||
| description: User-defined clipping planes applied to a batched 3D Tileset, point cloud, and model. | |||
| description: Demonstrates how to add to a mesh 3D Tileset, point cloud 3D Tileset, and glTF model. Useful for exploring interiors or cutting away parts of geometry. | |||
There was a problem hiding this comment.
"Demonstrates how to add clipping planes to a mesh..."?
| title: AEC Clipping | ||
| title: Design Model – Terrain Inset |
There was a problem hiding this comment.
I believe "AEC" is a fairly strong search term but has been removed from all of these sandcastles. Just want to make sure that's what we want?
There was a problem hiding this comment.
Good point. I think we should consider indexing search terms that are not necessarily part of the title or description, but we'll want to discuss that plan around this. Let's roll as-is with these for now.
| @@ -2,5 +2,6 @@ legacyId: Cesium Inspector.html | |||
| title: Cesium Inspector | |||
| description: Use the cesium inspector as a debugging tool for different primitives. | |||
| labels: | |||
| - Showcases | |||
| - Development | |||
There was a problem hiding this comment.
This isn't a development sandcastle so I don't think it should have this label? It might end up being the only one in production
| @@ -2,6 +2,5 @@ legacyId: Multiple Synced Views.html | |||
| title: Multiple Synced Views | |||
| description: Multiple views synced across time and space. | |||
| labels: | |||
| - Beginner | |||
| - Showcases | |||
| - 2D | |||
There was a problem hiding this comment.
2D what? is "2D View" more accurate/descriptive?
There was a problem hiding this comment.
Updated this and the other instance of "2D" to "2D View".
| @@ -1,6 +1,6 @@ | |||
| legacyId: Star Burst.html | |||
| title: Star Burst | |||
| description: Star burst overlapping billboards. | |||
| title: Expand Clustered Billboards | |||
There was a problem hiding this comment.
I wonder if the slug and filepath should change for the sandcastles that you changed the title of? 🤔
There was a problem hiding this comment.
For the sake of avoiding bus this late in the game, let's update this in the next pass.
|
@ggetz updated with 2 missing sandcastles and the changes to the gaussian splat one. The description on it needs reviewed again I think. |
| - Tutorials | ||
| - Showcases |
There was a problem hiding this comment.
Please adjust this one as you see fit. I know we were removing the "Tutorials" and I don't think this one needs to be a "Showcase"
There was a problem hiding this comment.
I'm going to mark this as "Voxels" since it's very much related in terms of the rendering techniques used.
|
Thanks for the review @jjspace! In the interest of time, I'm going to merge this myself. |
Description
Part of #12864, this contains an initial content pass on existing sandcastle examples, especially for labels and descriptions.
This is certainly not the final content pass; This is motivated by having a more reasonable set of examples for the landing page, and more navigable labels.
Issue number and link
N/A
Testing plan
Content-only changes. A sanity check on the YAML formatting, and if time verify spelling and grammar.