Small gulpfile updates #12957
Small gulpfile updates #12957
Conversation
|
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
| const zipUrl = `${deployUrl}Cesium-${version}.zip`; | ||
| const npmUrl = `${deployUrl}cesium-${version}.tgz`; | ||
| const coverageUrl = `${devDeployUrl}Build/Coverage/index.html`; | ||
| const coverageUrl = `${deployUrl}Build/Coverage/index.html`; |
There was a problem hiding this comment.
I believe this link is already broken in main, but it does not appear to be fixed with this change; https://ci-builds.cesium.com/cesium/small-gulpfile-updates/Build/Coverage/index.html is still a 404 equivalent.
Was this update attempting to address the broken link, or was it targeted at something else?
There was a problem hiding this comment.
@ggetz this was simply because I noticed these 3 urls were using different variables and probably should be consistent (functionally it's exactly the same). I did not actually check the link itself.
There was a problem hiding this comment.
Got it. I just checked and it appears to be an issue with the GitHub Actions workflow, not the gulpfile. Out of scope for this PR.
2 participants
Description
A few small tweaks/cleanup items to the gulpfile that I noticed while working on #12904
I specifically never realized there were links added to the github status until @ggetz clicked one the other day. This hopefully makes it more clear. I also prefixed them all the same so they should now show up next to each other alphabetically unlike before.
Issue number and link
no issue
Testing plan
npm run website-releaseworks as expectedAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change