Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -425,17 +425,6 @@ export async function buildDocsWatch() {
return gulp.watch(sourceFiles, buildDocs);
}

function combineForSandcastle() {
const outputDirectory = join("Build", "Sandcastle", "CesiumUnminified");
return buildCesium({
development: false,
minify: false,
removePragmas: false,
node: false,
outputDirectory: outputDirectory,
});
}

export const websiteRelease = gulp.series(
buildEngine,
buildWidgets,
Expand All @@ -447,14 +436,23 @@ export const websiteRelease = gulp.series(
node: false,
});
},
function () {
function websiteReleaseBuildMinified() {
return buildCesium({
minify: true,
removePragmas: true,
node: false,
});
},
combineForSandcastle,
function combineForSandcastle() {
const outputDirectory = join("Build", "Sandcastle", "CesiumUnminified");
return buildCesium({
development: false,
minify: false,
removePragmas: false,
node: false,
outputDirectory: outputDirectory,
});
},
buildDocs,
);

Expand Down Expand Up @@ -712,17 +710,21 @@ export async function deploySetVersion() {
export async function deployStatus() {
const status = argv.status;
const message = argv.message;

const deployUrl = `${devDeployUrl}`;
const zipUrl = `${deployUrl}Cesium-${version}.zip`;
const npmUrl = `${deployUrl}cesium-${version}.tgz`;
const coverageUrl = `${devDeployUrl}Build/Coverage/index.html`;
const coverageUrl = `${deployUrl}Build/Coverage/index.html`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this link is already broken in main, but it does not appear to be fixed with this change; https://ci-builds.cesium.com/cesium/small-gulpfile-updates/Build/Coverage/index.html is still a 404 equivalent.

Was this update attempting to address the broken link, or was it targeted at something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggetz this was simply because I noticed these 3 urls were using different variables and probably should be consistent (functionally it's exactly the same). I did not actually check the link itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I just checked and it appears to be an issue with the GitHub Actions workflow, not the gulpfile. Out of scope for this PR.


return Promise.all([
setStatus(status, deployUrl, message, "deployment"),
setStatus(status, zipUrl, message, "zip file"),
setStatus(status, npmUrl, message, "npm package"),
setStatus(status, coverageUrl, message, "coverage results"),
setStatus(status, deployUrl, message, "deploy / artifact: deployment"),
setStatus(status, zipUrl, message, "deploy / artifact: zip file"),
setStatus(status, npmUrl, message, "deploy / artifact: npm package"),
setStatus(
status,
coverageUrl,
message,
"deploy / artifact: coverage results",
),
]);
}

Expand Down