fix reading Array(Varian(String, Int32)) and similar when array has no common component class #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for such cases, similar to nullable columns
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in reading arrays of variant types (e.g., Array(Variant(String, Int32))) where elements can have different types. The fix treats variant arrays similarly to nullable arrays by using Object[] instead of trying to find a common component class.
Key Changes:
- Modified array reading logic to handle variant types by using
Object[]for storage - Added integration test coverage for arrays containing mixed-type variant elements
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BinaryStreamReader.java | Updated condition to use Object[] for variant type arrays, preventing class cast exceptions |
| DataTypeTests.java | Added test case validating arrays with mixed String/Int32 variant elements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
|
Client V1 CoverageCoverage Report
Class Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixed reading Array(Varian(String, Int32)) columns by using Object[] for such cases, similar to nullable columns
Closes #2602
Checklist
Delete items not relevant to your PR: