Skip to content

fix reading Array(Varian(String, Int32)) and similar when array has no common component class #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chernser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix reading Array(Varian(String, Int32)) and similar when array has no common component class #2687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/BinaryStreamReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ public ArrayValue readArray(ClickHouseColumn column) throws IOException {

public ArrayValue readArrayItem(ClickHouseColumn itemTypeColumn, int len) throws IOException {
ArrayValue array;
if (itemTypeColumn.isNullable()) {
if (itemTypeColumn.isNullable() || itemTypeColumn.getDataType() == ClickHouseDataType.Variant) {
array = new ArrayValue(Object.class, len);
for (int i = 0; i < len; i++) {
array.set(i, readValue(itemTypeColumn));
Expand Down
12 changes: 12 additions & 0 deletions client-v2/src/test/java/com/clickhouse/client/datatypes/DataTypeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,18 @@ public void testVariantWithArrays() throws Exception {
"[[a, b], [c, d]]",
"[[e, f], [j, h]]",
});

testVariantWith("arrays", new String[]{"field Array(Variant(String, Int32))"},
new Object[]{
new Object[]{1, 2},
new Object[]{"a", 3},
new Object[]{3, "d"}
},
new String[]{
"[1, 2]",
"[a, 3]",
"[3, d]",
});
}

@Test(groups = {"integration"})
Expand Down
Loading