-
Notifications
You must be signed in to change notification settings - Fork 388
CI: Remove .cache caching from GitHub Actions workflows #6097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🎭 Playwright Test Results⏰ Completed at: 10/19/2025, 03:59:25 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/19/2025, 03:43:41 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 11.7 MB (baseline 11.7 MB) • ⚪ 0 B_Main entry bundles and manifests_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | ------------------------ | ------- | ------- | ------------------ | ------------------ | ------------------ | | assets/index-CtdCLNdd.js | 9.67 MB | 9.67 MB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/index-DOdupr_x.js | 2.02 MB | 2.02 MB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/index-PESgPnbc.js | 507 B | 507 B | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B |Graph Workspace — 706 kB (baseline 706 kB) • ⚪ 0 B_Graph editor runtime, canvas, workflow orchestration_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | ---------------------------- | ------ | ------ | ------------------ | ------------------ | ------------------ | | assets/GraphView-BtlKFHvX.js | 706 kB | 706 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B |Views & Navigation — 7.99 kB (baseline 7.99 kB) • ⚪ 0 B_Top-level views, pages, and routed surfaces_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | --------------------------------- | ------- | ------- | ------------------ | ------------------ | ------------------ | | assets/UserSelectView-DjvAHfN5.js | 7.99 kB | 7.99 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B |Panels & Settings — 74.8 kB (baseline 74.8 kB) • ⚪ 0 B_Configuration panels, inspectors, and settings screens_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | ------------------------------------ | ------- | ------- | ------------------ | ------------------ | ------------------ | | assets/AboutPanel-CLKaxNTg.js | 10.1 kB | 10.1 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/CreditsPanel-CNqxmfsr.js | 21.9 kB | 21.9 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/ExtensionPanel-HQ5RMX7X.js | 11.9 kB | 11.9 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/KeybindingPanel-B-XQIYLb.js | 15.1 kB | 15.1 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/ServerConfigPanel-Bx6_KxjP.js | 8.04 kB | 8.04 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/UserPanel-BIhpR5Ri.js | 7.76 kB | 7.76 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B |UI Components — 11.9 kB (baseline 11.9 kB) • ⚪ 0 B_Reusable component library chunks_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | ----------------------------------------------------------------- | ------- | ------- | ------------------ | ------------------ | ------------------ | | assets/ComfyQueueButton-Ca24HJzZ.js | 10.7 kB | 10.7 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js | 1.12 kB | 1.12 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B |Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 B_Stores, services, APIs, and repositories_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | ------------------------------------ | ------- | ------- | ------------------ | ------------------ | ------------------ | | assets/keybindingService-DPPz7ASj.js | 7.21 kB | 7.21 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | | assets/serverConfigStore-CMadDTUK.js | 2.79 kB | 2.79 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B |Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B_Helpers, composables, and utility bundles_ | File | Before | After | Δ Raw | Δ Gzip | Δ Brotli | | --------------------------- | ------- | ------- | ------------------ | ------------------ | ------------------ | | assets/mathUtil-CTARWQ-l.js | 1.07 kB | 1.07 kB | ⚪ 0 B | ⚪ 0 B | ⚪ 0 B | |
📊 Performance Analysis: Removal ImpactI've completed comprehensive performance testing to measure the impact of removing 🎯 Executive SummaryRecommendation: ✅ Proceed with removing Impact: Minimal to slightly positive performance impact (-1.2% total time on average) 📈 Performance Results
🔍 Key Findings
✅ What Caching Remains (and why it's better)This change preserves all effective caching:
🧪 MethodologyTwo test commits measured real-world performance on GitHub Actions runners:
Test runs:
📖 Full DocumentationComprehensive analysis available at: ✨ Benefits of This Change✅ No performance degradation Conclusion: The data supports proceeding with this PR. Removing |
Co-authored-by: snomiao <[email protected]>
This commit temporarily restores .cache caching to establish a baseline for performance comparison. The next commit will remove it again to measure the performance impact. Testing approach: 1. This commit: WITH .cache (baseline) 2. Next commit: WITHOUT .cache (comparison) 3. Analysis: Compare CI run times to quantify cache impact
…TH cache" This reverts commit 84b4956.
Documents the empirical testing and performance impact of removing .cache directory caching from GitHub Actions workflows. Key findings: - Removing .cache had minimal to slightly positive impact (-1.2%) - Cache miss rate was 100% during testing - Tool-specific caches remain and are more effective - Recommendation: Proceed with removal See docs/ci/remove-dot-cache.md for full analysis.
f9c8f81
to
846fb87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking more getting rid of the whole actions/cache
step in these cases, not just the .cache directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file?
Overview
Removes
.cache
directory caching from GitHub Actions workflows to observe performance impact and establish a baseline for future optimization decisions.Context
As discussed in #5988, the codebase has been evolving with components moving into the
/packages
directory structure, not just/src
. The current cache key hashing may not be capturing all relevant changes that affect the build, making the.cache
caching potentially ineffective or misleading.This PR removes the
.cache
path from all workflow cache configurations to:Changes
Removed
.cache
from the cache path configuration in 8 workflow files:ci-lint-format.yaml
- Kept tool-specific caches (.eslintcache, .prettierCache, .knip-cache, tsconfig.tsbuildinfo)ci-tests-storybook.yaml
- Removed from both build and chromatic jobs; kept storybook-static and tsconfig.tsbuildinfoci-tests-unit.yaml
- Kept coverage and .vitest-cacheapi-update-electron-api-types.yaml
- Kept tsconfig.tsbuildinfoapi-update-manager-api-types.yaml
- Kept tsconfig.tsbuildinfoapi-update-registry-api-types.yaml
- Kept tsconfig.tsbuildinforelease-draft-create.yaml
- Kept tsconfig.tsbuildinforelease-pypi-dev.yaml
- Kept dist and tsconfig.tsbuildinfoNote: Other caching mechanisms remain intact:
cache: 'pnpm'
in setup-node actions is unchangedTesting
Next Steps
After this PR merges, we can monitor workflow performance metrics and decide whether to:
/packages
directory structureFixes #5988
Original prompt
Fixes #5988
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
┆Issue is synchronized with this Notion page by Unito