Skip to content

CI: Remove .cache caching from GitHub Actions workflows #6097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 20, 2025
+0 −118
Merged

CI: Remove .cache caching from GitHub Actions workflows #6097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cc47eca
Initial plan
Copilot Oct 17, 2025
fb9694f
Remove .cache caching from GitHub Actions workflows
Copilot Oct 17, 2025
24db1fc
[test] Baseline test: Re-add .cache to measure performance WITH cache
snomiao Oct 19, 2025
fef02b5
Revert "[test] Baseline test: Re-add .cache to measure performance WI…
snomiao Oct 19, 2025
846fb87
[docs] Add comprehensive performance analysis for .cache removal
snomiao Oct 19, 2025
0566aa2
Delete docs/ci/remove-dot-cache.md
snomiao Oct 20, 2025
38695ae
[ci] Remove all actions/cache steps from workflows
snomiao Oct 20, 2025
ab16635
Revert "[ci] Remove all actions/cache steps from workflows"
snomiao Oct 20, 2025
3ce876f
Revert "Revert "[ci] Remove all actions/cache steps from workflows""
snomiao Oct 20, 2025
63de26f
Merge branch 'main' into copilot/remove-cache-from-github-action
snomiao Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/api-update-electron-api-types.yaml
View file
Open in desktop
Copy link
Contributor

@DrJKL DrJKL Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking more getting rid of the whole actions/cache step in these cases, not just the .cache directory

Copy link
Member

@snomiao snomiao Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

benchmark updated into pr desc

Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@ jobs:
node-version: lts/*
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
key: electron-types-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
electron-types-tools-cache-${{ runner.os }}-

- name: Update electron types
run: pnpm install --workspace-root @comfyorg/comfyui-electron-types@latest

Expand Down
17 changes: 0 additions & 17 deletions .github/workflows/api-update-manager-api-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,26 +31,9 @@ jobs:
node-version: lts/*
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
key: update-manager-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
update-manager-tools-cache-${{ runner.os }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Cache ComfyUI-Manager repository
uses: actions/cache@v4
with:
path: ComfyUI-Manager
key: comfyui-manager-repo-${{ runner.os }}-${{ github.run_id }}
restore-keys: |
comfyui-manager-repo-${{ runner.os }}-

- name: Checkout ComfyUI-Manager repository
uses: actions/checkout@v5
with:
Expand Down
17 changes: 0 additions & 17 deletions .github/workflows/api-update-registry-api-types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,9 @@ jobs:
node-version: lts/*
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
key: update-registry-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
update-registry-tools-cache-${{ runner.os }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Cache comfy-api repository
uses: actions/cache@v4
with:
path: comfy-api
key: comfy-api-repo-${{ runner.os }}-${{ github.run_id }}
restore-keys: |
comfy-api-repo-${{ runner.os }}-

- name: Checkout comfy-api repository
uses: actions/checkout@v5
with:
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/ci-lint-format.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,6 @@ jobs:
node-version: 'lts/*'
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
.eslintcache
tsconfig.tsbuildinfo
.prettierCache
.knip-cache
key: lint-format-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js,mts}', '*.config.*', '.eslintrc.*', '.prettierrc.*', 'tsconfig.json') }}
restore-keys: |
lint-format-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-
lint-format-cache-${{ runner.os }}-
ci-tools-cache-${{ runner.os }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile

Expand Down
26 changes: 0 additions & 26 deletions .github/workflows/ci-tests-storybook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,6 @@ jobs:
node-version: '20'
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
storybook-static
tsconfig.tsbuildinfo
key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }}
restore-keys: |
storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-
storybook-cache-${{ runner.os }}-
storybook-tools-cache-${{ runner.os }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile

Expand Down Expand Up @@ -115,19 +102,6 @@ jobs:
node-version: '20'
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
storybook-static
tsconfig.tsbuildinfo
key: storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', '*.config.*', '.storybook/**/*') }}
restore-keys: |
storybook-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-
storybook-cache-${{ runner.os }}-
storybook-tools-cache-${{ runner.os }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile

Expand Down
13 changes: 0 additions & 13 deletions .github/workflows/ci-tests-unit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,6 @@ jobs:
node-version: "lts/*"
cache: "pnpm"

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
coverage
.vitest-cache
key: vitest-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('src/**/*.{ts,vue,js}', 'vitest.config.*', 'tsconfig.json') }}
restore-keys: |
vitest-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-
vitest-cache-${{ runner.os }}-
test-tools-cache-${{ runner.os }}-

- name: Install dependencies
run: pnpm install --frozen-lockfile

Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/release-draft-create.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,6 @@ jobs:
node-version: 'lts/*'
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
tsconfig.tsbuildinfo
key: release-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
release-tools-cache-${{ runner.os }}-

- name: Get current version
id: current_version
run: echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/release-pypi-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,6 @@ jobs:
node-version: 'lts/*'
cache: 'pnpm'

- name: Cache tool outputs
uses: actions/cache@v4
with:
path: |
.cache
dist
tsconfig.tsbuildinfo
key: dev-release-tools-cache-${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
dev-release-tools-cache-${{ runner.os }}-

- name: Get current version
id: current_version
run: echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT
Expand Down