refactor: Replace @ts-ignore with proper type assertion for Modal theme props #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors TypeScript suppression comments by replacing all instances of @ts-ignore with proper type assertions for Modal theme props across 10 Modal components. The change improves type safety by using explicit type casting instead of suppressing TypeScript errors.
- Replaces
@ts-ignorecomments with proper TypeScript type assertion syntax - Uses
customThemeTModal as Modal['props']['theme']for consistent type casting - Maintains the same runtime behavior while improving type safety
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/publisher/EditSecretKeyModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/publisher/CreatePublisherModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/nodes/NodeVersionDeleteModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/nodes/NodeLogoModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/nodes/NodeEditModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/nodes/NodeDeleteModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/nodes/AdminNodeClaimModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/nodes/AdminCreateNodeFormModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/AccessTokens/CreateSecretKeyModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
| components/AccessTokens/CopyAccessKeyModal.tsx | Replace @ts-ignore with type assertion for Modal theme prop |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🎨 Chromatic Visual Testing Results
Check the visual changes and approve or request changes as needed. |
…me props Replace all instances of //@ts-ignore with proper TypeScript type assertion theme={customThemeTModal as Modal['props']['theme']} across Modal components to improve type safety and eliminate TypeScript suppression comments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Wrap verifyRepoPermissions function with useCallback to prevent re-creation on every render - Add missing dependencies to useEffect dependency array: currentStage, router, t, verifyRepoPermissions - Ensure stable function references for proper React hook dependency tracking 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
snomiao
force-pushed
the
sno-modal-theme-type
branch
from
8351da3 to
3b1fcf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Replace all instances of
//@ts-ignorewith proper TypeScript type assertion for Modal theme props• Use
theme={customThemeTModal as Modal['props']['theme']}across 10 Modal components• Improve type safety and eliminate TypeScript suppression comments
Test plan
🤖 Generated with Claude Code