Skip to content

refactor: Replace @ts-ignore with proper type assertion for Modal theme props #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Replace @ts-ignore with proper type assertion for Modal theme props #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45b7764
refactor: Replace @ts-ignore with proper type assertion for Modal the…
snomiao Aug 17, 2025
3b1fcf5
fix: Resolve ESLint exhaustive-deps warning in claim-my-node.tsx
snomiao Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions components/AccessTokens/CopyAccessKeyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ export const CopyAccessTokenModal: React.FC<CopyAccessTokenModalProps> = ({
size="sm"
onClose={onCloseModal}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
<Modal.Body className="!bg-gray-800 p-8 md:px-7 md:py-7">
Expand Down
3 changes: 1 addition & 2 deletions components/AccessTokens/CreateSecretKeyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ export const CreateSecretKeyModal: React.FC<CreateSecretKeyModalProps> = ({
size="sm"
onClose={onCloseModal}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
{/* <Modal.Header className="!bg-gray-800" /> */}
Expand Down
3 changes: 1 addition & 2 deletions components/nodes/AdminCreateNodeFormModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ export function AdminCreateNodeFormModal({
size="md"
onClose={onClose}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible={false}
>
<Modal.Body className="!bg-gray-800 p-8 md:px-9 md:py-8 rounded-none">
Expand Down
3 changes: 1 addition & 2 deletions components/nodes/AdminNodeClaimModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,7 @@ export function AdminNodeClaimModal({
onClose={onClose}
size="md"
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
<Modal.Header className="!bg-gray-800">
Expand Down
3 changes: 1 addition & 2 deletions components/nodes/NodeDeleteModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ export const NodeDeleteModal: React.FC<NodeDeleteModalProps> = ({
size="md"
onClose={onClose}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
<Modal.Body className="!bg-gray-800 p-8 md:px-9 md:py-8 rounded-none">
Expand Down
3 changes: 1 addition & 2 deletions components/nodes/NodeEditModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ export const NodeEditModal: React.FC<NodeEditModalProps> = ({
size="3xl"
onClose={onCloseEditModal}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
<Modal.Body className="!bg-gray-800 p-8 md:px-9 md:py-8 rounded-none ">
Expand Down
3 changes: 1 addition & 2 deletions components/nodes/NodeLogoModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ export function NodeLogoModal({ openLogoModal, onCloseModal }) {
size="2xl"
onClose={onCloseModal}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
<Modal.Header className="!bg-gray-800 px-8 py-8">
Expand Down
3 changes: 1 addition & 2 deletions components/nodes/NodeVersionDeleteModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ export const NodeVersionDeleteModal: React.FC<NodeVersionDeleteModalProps> = ({
size="md"
onClose={onCloseDeleteModal}
popup
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
dismissible
>
<Modal.Body className="!bg-gray-800 p-8 md:px-9 md:py-8 rounded-none">
Expand Down
3 changes: 1 addition & 2 deletions components/publisher/CreatePublisherModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ const CreatePublisherModal: React.FC<CreatePublisherModalProps> = ({
show={open}
onClose={onCloseModal}
size="xl"
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
popup
dismissible
>
Expand Down
3 changes: 1 addition & 2 deletions components/publisher/EditSecretKeyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ export function EditSecretKeyModal({ openModal, onCloseModal }) {
onClose={onCloseModal}
popup
dismissible
//@ts-ignore
theme={customThemeTModal}
theme={customThemeTModal as Modal['props']['theme']}
>
<Modal.Body className="!bg-gray-800 p-8 md:px-9 md:py-8">
<div className="space-y-6">
Expand Down
2 changes: 1 addition & 1 deletion pages/publishers/[publisherId]/claim-my-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ function ClaimMyNodePage() {
setPermissionCheckLoading(false)
}
},
[t]
[t, setPermissionCheckLoading]
)

useEffect(() => {
Expand Down
Loading