Skip to content

Conversation

y9v
Copy link
Member

@y9v y9v commented Aug 19, 2025

What does this PR do?
This PR adds input_truncated metric to appsec.waf.requests telemetry.

Motivation:
This change is extracted to a separate PR from #4839, since it required changes to libddwaf-rb gem.

Change log entry
None. This change is internal.

Additional Notes:
Follow up for #4839
Related libddwaf-rb PR: DataDog/libddwaf-rb#91

This PR is in draft mode until changes to libddwaf-rb are merged and released.

How to test the change?
CI and manual testing.

@y9v y9v self-assigned this Aug 19, 2025
@github-actions github-actions bot added the appsec Application Security monitoring product label Aug 19, 2025
Copy link

datadog-official bot commented Aug 19, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 98.41%
Total Coverage: 95.19% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3c3e080 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Aug 19, 2025

Benchmarks

Benchmark execution time: 2025-09-17 14:40:53

Comparing candidate commit 3c3e080 in PR branch add-input-truncation-metric-to-waf-requests-telemetry with baseline commit 2f7a9d3 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - intern_all 1000 repeated strings

  • 🟩 throughput [+1224.876op/s; +1288.036op/s] or [+5.368%; +5.645%]

@y9v y9v force-pushed the add-input-truncation-metric-to-waf-requests-telemetry branch 2 times, most recently from a9da013 to 11aafca Compare September 8, 2025 12:41
@y9v y9v marked this pull request as ready for review September 8, 2025 13:59
@y9v y9v requested review from a team as code owners September 8, 2025 13:59
@y9v y9v marked this pull request as draft September 8, 2025 14:15
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM

@y9v y9v force-pushed the add-input-truncation-metric-to-waf-requests-telemetry branch from 58480b6 to e82ec4a Compare September 15, 2025 15:32
@y9v y9v marked this pull request as ready for review September 17, 2025 08:33
@y9v y9v force-pushed the add-input-truncation-metric-to-waf-requests-telemetry branch from 0a94d8f to 86b9763 Compare September 17, 2025 14:03
@github-actions github-actions bot added the core Involves Datadog core libraries label Sep 17, 2025
@y9v y9v merged commit bac3a1c into master Sep 17, 2025
366 checks passed
@y9v y9v deleted the add-input-truncation-metric-to-waf-requests-telemetry branch September 17, 2025 14:48
@github-actions github-actions bot added this to the 2.22.0 milestone Sep 17, 2025
@y9v y9v removed the core Involves Datadog core libraries label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants