-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PR Gates - renaming [DOCS-10684] #29089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
Opened DOCS-11687 for editorial review. |
The "Executions" page in the app no longer exists, so links to it will 404. For now I'm just changing to the main PR Gates app page to avoid breaks, and we'll remove the full Explorer content & links in #30713
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joepeeples looks great, all the aliases and menu updates are good, I just flagged a few areas of copy where we might possibly keep "PR Gates" capitalized throughout for consistency but feel free to reject/accept as appropriate!
Capitalizing "PR Gates" consistently Co-authored-by: Alicia Scott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed a couple more ! But approved as non blocking :)
a couple more capitalization fixes Co-authored-by: Alicia Scott <[email protected]>
What does this PR do? What is the motivation?
Renames
Quality Gates
toPR Gates
.Important
This PR only renames the product, and does not change any other content. Any files in the diff that appear to be brand-new are actually just pre-existing files for which either the file name or file path has been renamed.
Actual content changes are made in #30713, done separately to limit scope and help focus reviews. That PR updates the content with new procedures for setting up and using the new PR Gates, and it's targeting this PR's branch to include the renaming changes. When we're ready to merge, I'll need to merge this renaming PR first, then rebase the content/product PR to
main
.Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes