Skip to content

PR Gates - new product flow [DOCS-10684] #30713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: joepeeples/10684-pr-gates
Choose a base branch
from

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jul 25, 2025

What does this PR do? What is the motivation?

Revises documentation for new PR Gates product.

Important

This PR builds on and targets the product renaming branch in #29089. When we're ready to merge, we need to merge the renaming PR first, then rebase this PR to main. This shouldn't affect any content being reviewed in the current PR.

Tip

For reviewers: Because of extensive revisions to multiple sections, the diff tab in GitHub looks pretty choppy and isn't great for reviewing. It's probably easier to review the preview as a whole, focusing on the main landing page and Setup page.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

Smol change for testing, open PR
@joepeeples joepeeples added WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) labels Jul 25, 2025
Copy link
Contributor

github-actions bot commented Jul 25, 2025

ℹ️ Documentation Team Review

No documentation team review is required for this pull request.

@joepeeples joepeeples changed the title PR Gates - new product flow PR Gates - new product flow [DOCS-10684] Jul 25, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label Jul 25, 2025
no Explorer view currently
Search not currently available, and no longer enough content to justify having a separate Manage page.

Also adds redirect alias for the removed page.
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jul 25, 2025
joepeeples added a commit that referenced this pull request Jul 31, 2025
The "Executions" page in the app no longer exists, so links to it will 404. For now I'm just changing to the main PR Gates app page to avoid breaks, and we'll remove the full Explorer content & links in #30713
@joepeeples joepeeples marked this pull request as ready for review August 1, 2025 21:25
@joepeeples joepeeples requested a review from a team as a code owner August 1, 2025 21:25
@joepeeples joepeeples requested a review from a team as a code owner August 6, 2025 19:18
@joepeeples joepeeples added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) labels Aug 8, 2025
@joepeeples
Copy link
Contributor Author

joepeeples commented Aug 8, 2025

Opened DOCS-11772 for editorial review.

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approving the PR. I just had one small suggestion and a comment re: a product name.

| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations |
| [**Software Composition Analysis**][12] | <li> Library vulnerability violations <li> Detected license violations |
| [**Code Coverage**][15] | <li> Total code coverage threshold <li> Patch code coverage threshold |
| [**Infrastructure as Code Scanning**][16] | <li> IaC vulnerability severity |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we recently changed the name to Infrastructure as Code Security. But it looks like the UI still refers to it as Infrastructure as Code Scanning. Could we pass this feedback along to the PR Gates PM?

[11]: https://learn.microsoft.com/en-us/azure/devops/repos/git/pull-request-status?view=azure-devops
[12]: https://app.datadoghq.com/integrations/github
[13]: https://app.datadoghq.com/integrations/azure-devops-source-code
[14]: https://docs.datadoghq.com/integrations/github/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[14]: https://docs.datadoghq.com/integrations/github/
[14]: /integrations/github/

: <br> - Vulnerabilities <br> - Detected licenses
| Source type | Condition types |
| --- | ----------- |
| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations |
| [**Static Code Analysis**][11] | <li> Code vulnerabilities <li> Code quality violations |

| Source type | Condition types |
| --- | ----------- |
| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations |
| [**Software Composition Analysis**][12] | <li> Library vulnerability violations <li> Detected license violations |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [**Software Composition Analysis**][12] | <li> Library vulnerability violations <li> Detected license violations |
| [**Software Composition Analysis**][12] | <li> Library vulnerabilities <li> Library license violations |

| --- | ----------- |
| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations |
| [**Software Composition Analysis**][12] | <li> Library vulnerability violations <li> Detected license violations |
| [**Code Coverage**][15] | <li> Total code coverage threshold <li> Patch code coverage threshold |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [**Code Coverage**][15] | <li> Total code coverage threshold <li> Patch code coverage threshold |
| [**Code Coverage**][15] | <li> Total code coverage <li> Patch code coverage |

| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations |
| [**Software Composition Analysis**][12] | <li> Library vulnerability violations <li> Detected license violations |
| [**Code Coverage**][15] | <li> Total code coverage threshold <li> Patch code coverage threshold |
| [**Infrastructure as Code Scanning**][16] | <li> IaC vulnerability severity |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [**Infrastructure as Code Scanning**][16] | <li> IaC vulnerability severity |
| [**Infrastructure as Code Scanning**][16] | <li> IaC vulnerabilities |


{{% /tab %}}
{{% tab "Static Analysis" %}}
{{% tab "Static Code Analysis" %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% tab "Static Code Analysis" %}}
{{% tab "Static Code Analysis (SAST)" %}}


{{< img src="pr_gates/setup/static_analysis_2.png" alt="A PR Gate rule that fails when one or more new code quality violations of error-level severity are contained in the repository" style="width:80%" >}}
{{< img src="pr_gates/setup/static_analysis_3.png" alt="A PR Gate rule that fails when one or more new code quality violations of error-level severity are contained in the repository" style="width:80%" >}}

{{% /tab %}}
{{% tab "Software Composition Analysis" %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% tab "Software Composition Analysis" %}}
{{% tab "Software Composition Analysis (SCA)" %}}


{{% /tab %}}
{{% tab "Software Composition Analysis" %}}

You can create rules to block code from being merged when your repository has a certain number of library vulnerabilities or forbidden licenses.
You can create rules to block code from being merged when a pull request introduces at least one library vulnerability or forbidden license of a certain severity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can create rules to block code from being merged when a pull request introduces at least one library vulnerability or forbidden license of a certain severity.
You can create rules to block code from being merged when a pull request introduces at least one library vulnerability of a certain severity or at least one library with a forbidden license.


You can evaluate and update quality control processes by accessing PR Gates rules on the [**PR Gates Rules** page][6]. Improve your deployment practices based on your project requirements and desired performance outcomes.
{{% tab "Code Coverage" %}}
You can create rules to block code from being merged when a pull request causes the repository's overall code coverage to fall below a certain percentage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can create rules to block code from being merged when a pull request causes the repository's overall code coverage to fall below a certain percentage.
You can create rules to block code from being merged when a pull request causes the repository's overall code coverage to fall below a certain percentage or if the patch coverage is below a certain threshold.


You can view information about who created, modified, and deleted PR Gates rules in [Audit Trail][3].
You can evaluate and update quality control processes by accessing PR Gates rules on the [**PR Gates Rules**][6] page. Improve your deployment practices based on your project requirements and desired performance outcomes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can evaluate and update quality control processes by accessing PR Gates rules on the [**PR Gates Rules**][6] page. Improve your deployment practices based on your project requirements and desired performance outcomes.
You can managed and update PR Gates rules on the [**PR Gates Rules**][6] page. Improve your security and quality practices based on your project requirements and risk tolerances.


{{< img src="pr_gates/audit_event.png" alt="A PR Gates event in Datadog Audit Trail" style="width:100%" >}}
This view is useful for developers who want to keep an eye on the PR gates for their build pipelines. You can see all of the rules defined by the organization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This view is useful for developers who want to keep an eye on the PR gates for their build pipelines. You can see all of the rules defined by the organization.
You can see all of the rules defined by the organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants