Skip to content

Conversation

@AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Aug 20, 2025

What does this PR do?

Modifis the ddev env test command to ensure that when run on an integration that has the e2e-env option set to False, end-to-end test do not run.

This fix also supersedes the previous quick fix we did (#20967) to ensure we were on time for release 7.70.0.

Motivation

This variable was respected when running with environment set to all but, if an environment was provided, end-to-end test would be launched. The dd_environment fixture is not available and it would break. Some integrations might have the fixture defined and this won't break but since it is not a requirement when no end-to-end tests are defined, we need to make sure the command does not break.

This became an issue once we started parallelizing tests per environment and we now run a lot of them passing the target environment. Even for integrations that do not have end-to-end tests.

Validation

When running before this comment for infinibad that has e2e set to False and no fixture defined we would get the following error:

ddev env test --base --dev infiniband py3.12
────────────────────────────────────────────────────────────────────── Infiniband ───────────────────────────────────────────────────────────────────────
─────────────────────────────────────────────────────────────────── Starting: py3.12 ────────────────────────────────────────────────────────────────────

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! _pytest.outcomes.Exit: NO E2E FIXTURE AVAILABLE !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

After the fix

ddev env test --base --dev infiniband py3.12
Selected target 'infiniband' does not have E2E tests to run. Skipping.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 96.74419% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (c00de20) to head (08d20b0).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AAraKKe AAraKKe marked this pull request as ready for review August 20, 2025 16:40
@AAraKKe AAraKKe requested a review from a team as a code owner August 20, 2025 16:40
@NouemanKHAL
Copy link
Member

Suggestion for the PR title: Ensure ddev env test skips environments with disabled e2e-env

NouemanKHAL
NouemanKHAL previously approved these changes Aug 20, 2025
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM! Nice!

steveny91
steveny91 previously approved these changes Aug 20, 2025
@AAraKKe AAraKKe changed the title Modify ddev env test to ensure that when an environment does not have e2e enabled the command does not run Ensure ddev env test skips environments when disabled by e2e-env Aug 21, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from NouemanKHAL and steveny91 August 21, 2025 09:25

Review from NouemanKHAL is dismissed. Related teams and files:

  • agent-integrations
    • ddev/src/ddev/cli/env/test.py
    • ddev/tests/cli/env/test_test.py

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • ddev/src/ddev/cli/env/test.py
    • ddev/tests/cli/env/test_test.py
@AAraKKe AAraKKe force-pushed the aarakke/fix-e2e-selection-for-specific-environment branch 2 times, most recently from 08d20b0 to d7f2e05 Compare August 22, 2025 13:25
@AAraKKe AAraKKe added this pull request to the merge queue Aug 22, 2025
Merged via the queue into master with commit 0c18c2a Aug 22, 2025
628 of 634 checks passed
@AAraKKe AAraKKe deleted the aarakke/fix-e2e-selection-for-specific-environment branch August 22, 2025 15:01
@AAraKKe AAraKKe mentioned this pull request Aug 22, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants