-
Couldn't load subscription status.
- Fork 1.5k
Ensure ddev env test skips environments when disabled by e2e-env #21119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure ddev env test skips environments when disabled by e2e-env #21119
Conversation
… e2e enabled the command does not run
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
|
Suggestion for the PR title: Ensure ddev env test skips environments with disabled e2e-env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM! Nice!
Review from NouemanKHAL is dismissed. Related teams and files:
- agent-integrations
- ddev/src/ddev/cli/env/test.py
- ddev/tests/cli/env/test_test.py
Review from steveny91 is dismissed. Related teams and files:
- agent-integrations
- ddev/src/ddev/cli/env/test.py
- ddev/tests/cli/env/test_test.py
08d20b0 to
d7f2e05
Compare
What does this PR do?
Modifis the
ddev env testcommand to ensure that when run on an integration that has thee2e-envoption set toFalse, end-to-end test do not run.This fix also supersedes the previous quick fix we did (#20967) to ensure we were on time for release 7.70.0.
Motivation
This variable was respected when running with environment set to
allbut, if an environment was provided, end-to-end test would be launched. Thedd_environmentfixture is not available and it would break. Some integrations might have the fixture defined and this won't break but since it is not a requirement when no end-to-end tests are defined, we need to make sure the command does not break.This became an issue once we started parallelizing tests per environment and we now run a lot of them passing the target environment. Even for integrations that do not have end-to-end tests.
Validation
When running before this comment for
infinibadthat hase2eset to False and no fixture defined we would get the following error:After the fix
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged