Skip to content

Conversation

@ThijsVroegh
Copy link
Contributor

@ThijsVroegh ThijsVroegh commented Nov 28, 2024

This pull request introduces several new functionalities and improvements in the image alignment and comparison features of the unraphael project. The most important changes include the addition of new functions for feature detection, homography computation, and image animation, as well as enhancements to the user interface for image comparison. Solves issues #98, #96 and #94

New functionalities:

  • src/unraphael/dash/align.py: Added functions detect_and_compute_features, match_features, compute_homography, apply_homography, and homography_matrix to support feature detection and homography computation for image alignment.
  • src/unraphael/dash/pages/4_compare.py: Introduced functions extract_foreground_mask, extract_outer_contour_from_mask, overlay_contours, warp_image_skimage, blend_images_skimage, and animate_images to enhance image processing capabilities.

User interface enhancements:

Code improvements:

  • src/unraphael/dash/widgets.py: Changed use_container_width to use_column_width in the show_images_widget and image_downloads_widget functions for better layout consistency. [1] [2]

@ThijsVroegh ThijsVroegh changed the title Add contour comparison and animation togehter with similarity metrics Add contour comparison and animation together with similarity metrics Nov 29, 2024
@ThijsVroegh ThijsVroegh marked this pull request as ready for review January 13, 2025 11:30
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀


import math
from typing import Callable
from typing import Callable, Tuple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from typing import Callable, Tuple
from typing import Callable, Tuple

Explicitly importing Tuple is not necessary, can just be tuple since Python 3.10

@stefsmeets stefsmeets merged commit 193b29f into main Jan 16, 2025
4 checks passed
@stefsmeets stefsmeets deleted the animate branch January 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants