Features: TakeProperties #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jiacheng Huang <[email protected]>
* add docs 0f /features/__rge__ * u * u * right , * Update features.py --------- Co-authored-by: Jiacheng Huang <[email protected]> Co-authored-by: Giovanni Volpe <[email protected]>
* add docs of /features/__xor__ * remove blank spaces --------- Co-authored-by: Jiacheng Huang <[email protected]>
* add docs of /features/__rand__ * Update features.py --------- Co-authored-by: Jiacheng Huang <[email protected]> Co-authored-by: Giovanni Volpe <[email protected]>
Co-authored-by: Jiacheng Huang <[email protected]>
JChonpca
changed the title
added 4 commits
July 28, 2025 22:00
Merged
Collaborator
There was a problem hiding this comment.
I think that the PR looks quite good, and the unittesting is good. You should check what is written in the docs and type hints, because to me it isn't clear from that text if it can also return torch tensors. And I also wrote some comments about a few smaller things
Pwhsky
requested changes
Sep 3, 2025
Collaborator
Pwhsky
left a comment
Pwhsky
left a comment
There was a problem hiding this comment.
My only comments are for some type hints, looks finished otherwise.
Pwhsky
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unittest, torch compatible, docs