-
Notifications
You must be signed in to change notification settings - Fork 157
Fix monorepo build args split and add test for getBuildOptions #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently in the buildpack our build args are joined together using "," instead of ".", so MONOREPO_BUILD_ARGS should split by commas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @sjjj986, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed an issue in the buildpack where MONOREPO_BUILD_ARGS
were being incorrectly parsed. Previously, the system expected these arguments to be separated by periods, but they are actually joined by commas. This change ensures that the build arguments for monorepos are now correctly interpreted, allowing builds to proceed as intended.
Highlights
- Monorepo Build Arguments Parsing: Changed the delimiter used to split the
MONOREPO_BUILD_ARGS
environment variable from a period (.
) to a comma (,
) within thegetBuildOptions
function. This corrects an issue where build arguments were not being parsed as expected.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue where MONOREPO_BUILD_ARGS
was being split by a dot instead of a comma. The change correctly updates the delimiter. I've added a suggestion to make the argument parsing more robust by handling empty strings and extra whitespace, which will prevent potential issues with the build command.
Fix monorepo build args split bug and add test for
getBuildOptions
.Currently in the buildpack our monorepo build args are joined together as a list using ",", but the adapter is currently parsing this env var by spliting with ".". This is a fix to make sure
MONOREPO_BUILD_ARGS
should split by commas instead