-
Notifications
You must be signed in to change notification settings - Fork 62
Dataloader move to universal from gpii-ops/gpii-dataloader #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rsal docker image
|
Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test". |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1212/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/1214/ |
mrtyler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| # components: the Preferences Server and the Flow Manager. | ||
| # | ||
| # It also starts a CouchDB container and loads the CouchDB data into | ||
| # It also starts a CouchDB container and data into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old text was correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, not sure how it got in and I didn't notice, reverted back to original text.
|
CI job passed: https://ci.gpii.net/job/universal-tests/1226/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/1229/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/1231/ |
This PR moves dataloader from original
gpii-ops/gpii-dataloaderrepo into universal.Main reasons behind this:
Most of the code was in universal already, and
gpii-ops/gpii-dataloadercontained basically only shell wrapper and the docker image. Work on new dataloader (GPII-3138 and #626) requires changes to the existing dataloader wrapper and therefore presented a good opportunity for the move.This is a continuation of gpii-ops/gpii-dataloader#6 PR.
Main changes:
I have tested this locally and plan to create corresponding PR and test for gpii-infra changes required.