This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Dataloader import #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR was GPII#696 and we agreed to combine the efforts via @klown's branch here and PR GPII#692 to universal
--- original PR text ---
This PR moves dataloader from original
gpii-ops/gpii-dataloaderrepo into universal.Main reasons behind this:
Most of the code was in universal already, and
gpii-ops/gpii-dataloadercontained basically only shell wrapper and the docker image. Work on new dataloader (GPII-3138 and GPII#626) requires changes to the existing dataloader wrapper and therefore presented a good opportunity for the move.This is a continuation of gpii-ops/gpii-dataloader#6 PR.
Main changes:
I have tested this locally and plan to create corresponding PR and test for gpii-infra changes required.