-
Notifications
You must be signed in to change notification settings - Fork 4k
Always open header logo link in the current tab #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always open header logo link in the current tab #3445
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
f895704
to
02a86ae
Compare
- Revalidate if the link is external in the `onClick`
02a86ae
to
358919b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLobally it looks like it refactors the code in a good way; but I think we should remove the target="_self"
from HeaderLogo
No description provided.