Skip to content

Conversation

@gregberge
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jul 7, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: d11ba8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 2 changed Jul 8, 2025, 8:32 AM
v2-cloudflare (Inspect) ✅ No changes detected - Jul 8, 2025, 8:36 AM
v2-vercel (Inspect) ✅ No changes detected - Jul 8, 2025, 8:35 AM

- Revalidate if the link is external in the `onClick`
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLobally it looks like it refactors the code in a good way; but I think we should remove the target="_self" from HeaderLogo

@gregberge gregberge merged commit d0a3f64 into main Jul 8, 2025
15 of 16 checks passed
@gregberge gregberge deleted the greg/rnd-7527-new-tab-linking-impacts-site-logo branch July 8, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants