Skip to content

Always open header logo link in the current tab #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025
Merged

Always open header logo link in the current tab #3445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7672bed
Always open header logo link in the current tab
gregberge Jul 7, 2025
358919b
Refactor login in link
gregberge Jul 7, 2025
d11ba8d
Use relative link for site logo
gregberge Jul 8, 2025
9fdf910
Avoid shadowing variable
gregberge Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/gitbook/src/components/Header/HeaderLogo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export async function HeaderLogo(props: HeaderLogoProps) {
return (
<Link
href={linker.toAbsoluteURL(linker.toPathInSite(''))}
target="_self"
className={tcls('group/headerlogo', 'min-w-0', 'shrink', 'flex', 'items-center')}
>
{customization.header.logo ? (
Expand Down
2 changes: 1 addition & 1 deletion packages/gitbook/src/components/primitives/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const Link = React.forwardRef(function Link(
{...domProps}
href={href}
onClick={onClick}
{...(externalLinksTarget === SiteExternalLinksTarget.Blank
{...(externalLinksTarget === SiteExternalLinksTarget.Blank && !domProps.target
? { target: '_blank', rel: 'noopener noreferrer' }
: {})}
>
Expand Down