Skip to content

Improve test coverage in test_tool_service #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 8, 2025
Merged

Improve test coverage in test_tool_service #241

merged 11 commits into from
Jul 8, 2025

Conversation

madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Jul 4, 2025 •
edited
Loading

✨ Feature / Enhancement PR

🚀 Summary (1–2 sentences)

  • Improves test coverage from 60% to 92% for tool_service
  • Overall coverage improves from 70% to 73%

Status

Needs update due to changes in PR #215

madhav165 added 8 commits July 1, 2025 16:34
@madhav165
Full coverage for test_verify_credentials
12d362f 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
Additional test_tool_service tests
2fe8937 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
Add MCP tool call test
d150cc2 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
More test_tool_service tests
02dccb0 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
Some more tests
f32862f 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
More test cases
a9bb627 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
test_tool_service at 90% coverage
000c97f 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
More tests
cee64fa 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165 madhav165 self-assigned this Jul 4, 2025
@madhav165 madhav165 marked this pull request as draft July 4, 2025 16:44
@madhav165
Copy link
Collaborator Author

Test cases need updates due to updates from PR #215

madhav165 added 2 commits July 7, 2025 18:41
@madhav165
Fix some test cases
148ddbf 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165
Linting and test cases
541af10 
Signed-off-by: Madhav Kandukuri <[email protected]>
@madhav165 madhav165 marked this pull request as ready for review July 7, 2025 18:13
crivetimihai
crivetimihai approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make smoketest and test all pass. Merging.

@crivetimihai crivetimihai merged commit 2e4f17a into main Jul 8, 2025
23 checks passed
@crivetimihai crivetimihai deleted the improve-test-coverage branch July 8, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivetimihai crivetimihai crivetimihai approved these changes

@kevalmahajan kevalmahajan Awaiting requested review from kevalmahajan kevalmahajan is a code owner

Assignees

@madhav165 madhav165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhav165 @crivetimihai