Improve test coverage in test_tool_service

mcpgateway/services/gateway_service.py

@@ -624,7 +624,6 @@ async def check_health_of_gateways(self, gateways: List[DbGateway]) -> bool:
         # Reuse a single HTTP client for all requests
         async with httpx.AsyncClient() as client:
             for gateway in gateways:
-
                 logger.debug(f"Checking health of gateway: {gateway.name} ({gateway.url})")
                 try:
                     # Ensure auth_value is a dict

mcpgateway/services/tool_service.py

@@ -413,7 +413,8 @@ async def invoke_tool(self, db: Session, name: str, arguments: Dict[str, Any]) -
                 raise ToolNotFoundError(f"Tool '{name}' exists but is inactive")
             raise ToolNotFoundError(f"Tool not found: {name}")
 
-        is_reachable = db.execute(select(DbTool.reachable).where(slug_expr == name)).scalar_one_or_none()
+        # is_reachable = db.execute(select(DbTool.reachable).where(slug_expr == name)).scalar_one_or_none()
+        is_reachable = tool.reachable
 
         if not is_reachable:
             raise ToolNotFoundError(f"Tool '{name}' exists but is currently offline. Please verify if it is running.")
@@ -452,7 +453,7 @@ async def invoke_tool(self, db: Session, name: str, arguments: Dict[str, Any]) -
                     response = await self._http_client.get(final_url, params=payload, headers=headers)
                 else:
                     response = await self._http_client.request(method, final_url, json=payload, headers=headers)
-                await response.raise_for_status()
+                response.raise_for_status()
 
                 # Handle 204 No Content responses that have no body
                 if response.status_code == 204:
@@ -472,10 +473,7 @@ async def invoke_tool(self, db: Session, name: str, arguments: Dict[str, Any]) -
             elif tool.integration_type == "MCP":
                 transport = tool.request_type.lower()
                 gateway = db.execute(select(DbGateway).where(DbGateway.id == tool.gateway_id).where(DbGateway.enabled)).scalar_one_or_none()
-                if gateway.auth_type == "bearer":
-                    headers = decode_auth(gateway.auth_value)
-                else:
-                    headers = {}
+                headers = decode_auth(gateway.auth_value)
 
                 async def connect_to_sse_server(server_url: str) -> str:
                     """
@@ -527,7 +525,7 @@ async def connect_to_streamablehttp_server(server_url: str) -> str:
                 filtered_response = extract_using_jq(content, tool.jsonpath_filter)
                 tool_result = ToolResult(content=filtered_response)
             else:
-                return ToolResult(content="Invalid tool type")
+                return ToolResult(content=[TextContent(type="text", text="Invalid tool type")])
 
             return tool_result
         except Exception as e:

mcpgateway/utils/db_isready.py

@@ -55,6 +55,7 @@
     await wait_for_db_ready()          # asynchronous
     wait_for_db_ready(sync=True)       # synchronous / blocking
 """
+
 # Future
 from __future__ import annotations
 

mcpgateway/utils/redis_isready.py

@@ -63,6 +63,7 @@
 import time
 from typing import Any, Optional
 
+# First-Party
 # First Party imports
 from mcpgateway.config import settings
 
@@ -133,6 +134,7 @@ def _probe(*_: Any) -> None:
         """
         try:
             # Import redis here to avoid dependency issues if not used
+            # Third-Party
             from redis import Redis
         except ImportError:  # pragma: no cover - handled at runtime for the CLI
             sys.stderr.write("redis library not installed - aborting (pip install redis)\n")