Document that Iterator(image, region) constructors of "ImageFrequency" initialize at the begin, add GTest unit test #4827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Testing
|
/azp run ITK.Linux.Python |
dzenanz
approved these changes
Aug 29, 2024
- Follow-up to pull request InsightSoftwareConsortium#4815 commit 66e6d8b "ENH: Add GoogleTest unit test `ImageRegionIterator.IsConstructedAtBegin`" Note: `FrequencyImageRegionIteratorWithIndex` and `FrequencyImageRegionConstIteratorWithIndex` are excluded from this commit, because they do not yet compile.
Explicitly specify that those constructors from iterator types of Modules/Filtering/ImageFrequency initialize the iterator at the begin of the region. Note: `FrequencyImageRegionIteratorWithIndex` and `FrequencyImageRegionConstIteratorWithIndex` are excluded from this commit, because they do not yet compile. - Follow-up to pull request InsightSoftwareConsortium#4815 commit 9eb1359 "DOC: Document Iterator(image, region) constructors initializing at begin"
N-Dekker
force-pushed
the
FrequencyIterators-AreConstructedAtBegin
branch
from
9ccdecc to
4076588
Compare
phcerdan
added a commit
to phcerdan/ITK
that referenced
this pull request
Sep 10, 2024
Test it via recently added gtest (see InsightSoftwareConsortium#4827) Closes InsightSoftwareConsortium#4828
4 tasks
phcerdan
added a commit
to phcerdan/ITK
that referenced
this pull request
Sep 11, 2024
Test it via recently added gtest (see InsightSoftwareConsortium#4827) Closes InsightSoftwareConsortium#4828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to pull request Document that Iterator(image, region) constructors initialize at the begin, add GTest unit test #4815
Note:
FrequencyImageRegionIteratorWithIndexandFrequencyImageRegionConstIteratorWithIndexare excluded from this pull request, because they do not yet compile. (As is observed by STYLE: Remove unused "itkFrequencyImageRegion*IteratorWithIndex.h" files #4828)