STYLE: Remove unused "itkFrequencyImageRegion*IteratorWithIndex.h" files

[N-Dekker]

Both FrequencyImageRegionIteratorWithIndex and FrequencyImageRegionConstIteratorWithIndex appear unused and untested. Attempts to use them would trigger compile errors.

An attempt to use FrequencyImageRegionIteratorWithIndex triggered:

error C3210: 'ImageRegionIteratorWithIndex<itk::Image<int,2> >': a member using-declaration can only be applied to a base class member

An attempt to use FrequencyImageRegionConstIteratorWithIndex triggered:

error C2679: binary '=': no operator found which takes a right-hand operand of type 'const itk::Point<T,3>' (or there is no acceptable conversion)

This commit removes their header files. It also removes the suggestion to use FrequencyImageRegionIteratorWithIndex from the documentation of UnaryFrequencyDomainFilter.

[N-Dekker]

@phcerdan Sorry Pablo 🤷 but if those iterators don't compile and don't have any test, I think it's better not to have them in the main branch!

[phcerdan]

They are used in the IsotropicWavelets module. We should move the tests from there here.

These filters are useful, prefer a fix rather than removal.

[N-Dekker]

@phcerdan Thanks for your very quick response, Pablo!

They are used in the IsotropicWavelets module. We should move the tests from there here.

Sorry, but how can they possibly be used when they cannot compile at all? Even the very first revision of those two iterators (six years ago, e16d0bc) would have those compile errors, as far as I can see.

The other six iterator types from Modules/Filtering/ImageFrequency compile fine, it's just these two. So I suspect that these two are not really necessary. 🤷

[phcerdan]

Thanks @N-Dekker, I am out of office and away from keyboard to give a detailed answer about the history of the filters. But if you don't want to work on a fix, let me do it when I am back.

Thanks

[N-Dekker]

But if you don't want to work on a fix, let me do it when I am back.

OK, thanks Pablo. Rather than just a quick-fix of those compile errors, I hope you can add a test that will show the usefulness of those two iterators.

• By the way, I encountered those compile errors when I was busy writing a unit test for pull request Document that Iterator(image, region) constructors of "ImageFrequency" initialize at the begin, add GTest unit test #4827, testing that Iterator(image, region) yields an iterator at the begin of the region. This test passed well for the other six ImageFrequency iterator types. Please have a look, if you still have time!