-
Notifications
You must be signed in to change notification settings - Fork 162
Disallow duplicate VRF keys for pool registration #5229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d09168
to
d6fa6b0
Compare
d6fa6b0
to
9fedfb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome PR. I love all the additions to the test suite.
However, it is missing one critical part. Once we hard fork into protocol version 11, the contents of psVRFKeyHashes
will be empty, which will totally screw up the whole logic in this PR.
We need to also adjust the HARDFORK
rule to populate that field with data from all of the psStakePools
and psFutureStakePools
on the hard fork boundary.
d51288f
to
7d99298
Compare
1091e1f
to
d112625
Compare
b019185
to
71e0b15
Compare
6ab76ba
to
66d6026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a beautiful piece of work!
Thank you!
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/HardForkSpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/HardForkSpec.hs
Outdated
Show resolved
Hide resolved
66d6026
to
7e3ce50
Compare
to make it easier to add branches
7e3ce50
to
a5543c1
Compare
Description
Whenever we register or re-register a pool, starting with version 11, we check that the provided VRF key is not in use by another pool.
When we reap the pools, we also forget their VRF keys, so they become free to be used again.
Resolves #5159
Checklist
CHANGELOG.md
files updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh
).scripts/cabal-format.sh
).scripts/gen-cddl.sh
)hie.yaml
updated (usescripts/gen-hie.sh
).