Changed the type of Tx size to Word32 #5238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/tx-size-word32
branch
2 times, most recently
from
e8df1b2 to
9745172
Compare
lehins
requested changes
Aug 27, 2025
There was a problem hiding this comment.
Looks good overall, but we need to guard against overflows and underflows.
In this particular PR there would be no danger for mainnet, since there are other checks in place that would prevent it from happen, however, it does not mean we should not do our due diligence.
Soupstraw
force-pushed
the
jj/tx-size-word32
branch
from
e8cbffa to
459e0a7
Compare
Soupstraw
force-pushed
the
jj/tx-size-word32
branch
2 times, most recently
from
8167b20 to
5d690ff
Compare
Soupstraw
force-pushed
the
jj/tx-size-word32
branch
2 times, most recently
from
50b58d3 to
5513026
Compare
Soupstraw
force-pushed
the
jj/tx-size-word32
branch
2 times, most recently
from
04b2c18 to
c31b4a4
Compare
Co-authored-by: Alexey Kuleshevich <[email protected]>
Soupstraw
force-pushed
the
jj/tx-size-word32
branch
from
c31b4a4 to
b6b8235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #5181
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).