Skip to content

Conversation

@baptistegrimaud
Copy link
Contributor

@baptistegrimaud baptistegrimaud commented Dec 17, 2025

Closes #608.

Description

Remove the checks and warning logs related to GraalVM and the 'js' language extension from the JavaScript Modules Engine initialization code.

Why were these checks removed?

  • GraalVM Check: The code previously warned if GraalVM was not detected, but this is no longer relevant as we've decided to only use OpenJDK (in our Docker images).
  • 'js' Extension Check: The 'js' extension is specific to GraalVM and enables JavaScript execution within the JVM. Since OpenJDK does not support GraalVM language extensions, this check is obsolete and has been removed.

Impact

  • The engine initialization is now cleaner and does not log unnecessary warnings when running on OpenJDK.
  • There is no equivalent check for JavaScript engine support in OpenJDK, as it does not provide GraalVM's polyglot features.

Tip

Documentation to guide the reviews: How to do a code review

@baptistegrimaud baptistegrimaud marked this pull request as ready for review December 17, 2025 15:36
@baptistegrimaud baptistegrimaud requested a review from a team as a code owner December 17, 2025 15:36
Copilot AI review requested due to automatic review settings December 17, 2025 15:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes obsolete GraalVM-specific validation code from the JavaScript Modules Engine initialization. The changes align with the decision to standardize on OpenJDK in Docker images, eliminating unnecessary runtime checks and warning messages.

Key Changes:

  • Removed GraalVM version detection and warning logic
  • Removed 'js' language extension validation check
  • Cleaned up related imports and method calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@baptistegrimaud baptistegrimaud enabled auto-merge (squash) December 17, 2025 21:08
@baptistegrimaud baptistegrimaud merged commit d579c06 into main Dec 17, 2025
20 checks passed
@baptistegrimaud baptistegrimaud deleted the remove-checks-on-graalvm branch December 17, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove GraalVM requirement

3 participants