Make issymmetric unconditionally true for Numbers
#1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1435 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 34 34
Lines 15900 15900
=======================================
Hits 14929 14929
Misses 971 971 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
changed the title
isnan check in issymetric/ishermitian for Numbersissymmetric unconditionally true for Numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1436 (comment), this PR changes
issymmetricto always returntrueforNumbers, and analogouslyishermitianfor real numbers. This makes these methods type-based instead of value-based. The only exception at present was forNaNand related numbers that didn't satisfyx == x. This PR ignores such cases.