Skip to content

Make issymmetric unconditionally true for Numbers #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make issymmetric unconditionally true for Numbers #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d5a4f
`isnan` check in `issymetric`/`ishermitian` for `Number`s
jishnub Sep 6, 2025
ca9a31c
Dispatch on type in `issymmetric`
jishnub Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,7 +1350,7 @@ function issymmetric(A::AbstractMatrix)
return true
end

issymmetric(x::Number) = x == x
issymmetric(x::Number) = true

"""
ishermitian(A) -> Bool
Expand Down Expand Up @@ -1389,7 +1389,7 @@ function ishermitian(A::AbstractMatrix)
return true
end

ishermitian(x::Number) = (x == conj(x))
ishermitian(x::Number) = isreal(x)

# helper function equivalent to `iszero(v)`, but potentially without the fast exit feature
# of `all` if this improves performance
Expand Down
8 changes: 8 additions & 0 deletions test/generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,4 +943,12 @@ end
@test B == A2
end

@testset "issymmetric/ishermitian for Numbers" begin
fsym(x) = Val(issymmetric(x))
@test @inferred(fsym(2)) isa Val{true}
@test @inferred(fsym(2im)) isa Val{true}
fherm(x) = Val(ishermitian(x))
@test @inferred(fherm(2)) isa Val{true}
end

end # module TestGeneric