Skip to content

Update jac_lin_coord methods #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 27, 2025
Merged

Conversation

arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Jul 9, 2025

The linear Jacobian part is independent of x, so passing it became unnecessary.

  • jac_lin_coord(nlp, x)jac_lin_coord(nlp)
  • jac_lin_coord!(nlp, x, vals)jac_lin_coord!(nlp, vals)

Closes #404

@amontoison
Copy link
Member

@arnavk23 It is a breaking change if we drop the signature with x, we should still support the old API and make it deprecated.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnavk23
Copy link
Contributor Author

@tmigot All test have passed except the breakage/upload one.

@arnavk23 arnavk23 requested a review from tmigot July 12, 2025 08:46
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 for these changes. I gave some thoughts about @amontoison 's comment, and it's a good idea to deprecate these functions instead of removing them directly.
Using the macro @deprecate when somebody uses the "old" variant it should receive a warning saying that the function is deprecated and point to the variant.

@arnavk23 arnavk23 requested a review from tmigot July 15, 2025 03:36
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 for the changes. I made some comments.
I think we also miss the functions jprod and jtprod

arnavk23 and others added 8 commits July 23, 2025 16:38
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
@tmigot
Copy link
Member

tmigot commented Jul 23, 2025

We also need to remove the x for the function jprod_lin, jprod_lin!, jtprod_lin and jtprod_lin!

@arnavk23 arnavk23 requested a review from tmigot July 23, 2025 18:49
@arnavk23 arnavk23 requested a review from tmigot July 26, 2025 20:29
arnavk23 and others added 5 commits July 27, 2025 19:19
@arnavk23 arnavk23 requested a review from tmigot July 27, 2025 13:57
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 !

@tmigot tmigot merged commit 3091fb0 into JuliaSmoothOptimizers:main Jul 27, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jac_lin_coord doesn't need to know x
3 participants