Diff view

[lievenhey]

No description provided.

[lievenhey]

[lievenhey]

The description of the table is not correct and the data might be a bit crappy

[milianw]

The description of the table is not correct and the data might be a bit crappy

is this still open or did you fix it now?

[milianw]

dito

[lievenhey]

I know I still need to update the test files, but the approach taken to create the diff view should be better now.

[lievenhey]

I tried adding diffing to the perfparser, but I don't know if this is the right way. Please tell me if the current way is acceptable or if I should try another one.

[lievenhey]

Still not done, I just wanted to save my progess

[milianw]

nearly done, this is looking really good now, great work and idea with just adding the diff as another cost - I really like that!

[milianw]

can you please squash the patches and add test coverage as well as a meaningful commit message. I would expect a basic summary therein (remember, the What and Why is important):

• which part of the perf diff feature set is supported?
• what problem does the diffcostproxy solve?
• how does on use this new feature?

furthermore, please also add a quick way to diff files from the command line, something like

hotspot --diff perf.data.old perf.data

[GitMensch]

Other than the missing tests the docs would need an update.
If I knew how to test that locally and there's a CI build providing an AppImage of this I'd give this a test.

[GitMensch]

Can you please update the docs (README and possibly a screenshot), too?