fix: Do not add request-termination on TLSRoute / TCPRoute #7700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pmalek
reviewed
Sep 12, 2025
| "message": "no existing backendRef provided", | ||
| }, | ||
| }) | ||
| if strings.Contains(service.Service.Protocol, "http") || strings.Contains(service.Service.Protocol, "grpc") { |
There was a problem hiding this comment.
strings package has to be imported for the build to pass.
This was referenced Sep 19, 2025
Closed
|
Hello, |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
…ute (#7700) (#7720) * fix: Do not add request-termination on TLSRoute / TCPRoute * fix: add import of strings and check nil * fix unit tests and golden test cases * add changelog --------- Co-authored-by: Victor Durand <[email protected]>
team-k8s-bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
…ute (#7700) (#7720) * fix: Do not add request-termination on TLSRoute / TCPRoute * fix: add import of strings and check nil * fix unit tests and golden test cases * add changelog --------- Co-authored-by: Victor Durand <[email protected]> (cherry picked from commit cc67509)
randmonkey
added a commit
that referenced
this pull request
Sep 22, 2025
…ute (#7700) (#7720) * fix: Do not add request-termination on TLSRoute / TCPRoute * fix: add import of strings and check nil * fix unit tests and golden test cases * add changelog --------- Co-authored-by: Victor Durand <[email protected]>
randmonkey
added a commit
that referenced
this pull request
Sep 22, 2025
…ute (#7700) (#7720) (#7729) * fix: Do not add request-termination on TLSRoute / TCPRoute * fix: add import of strings and check nil * fix unit tests and golden test cases * add changelog --------- (cherry picked from commit cc67509) Co-authored-by: Tao Yi <[email protected]> Co-authored-by: Victor Durand <[email protected]>
randmonkey
added a commit
that referenced
this pull request
Sep 22, 2025
…ute (#7700) (#7720) (#7730) * fix: Do not add request-termination on TLSRoute / TCPRoute * fix: add import of strings and check nil * fix unit tests and golden test cases * add changelog --------- Co-authored-by: Victor Durand <[email protected]>
|
Cherry-picked in #7720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The request-termination was added to return 500 error when no backendRef is provided, this should not be done on TLS/TCP route as HTTP errors are not valid with those protocols. Also the request-termination plugin is only accepting HTTP/HTTPS/GRPC/GRPCS
https://developer.konghq.com/plugins/request-termination/reference/
Which issue this PR fixes:
#7699
#fix 7699
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR