Skip to content

fix: Do not add request-termination on TLSRoute / TCPRoute #7700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Do not add request-termination on TLSRoute / TCPRoute #7700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions internal/dataplane/translator/translate_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,15 @@
if service.Plugins == nil {
service.Plugins = make([]kong.Plugin, 0)
}
service.Plugins = append(service.Plugins, kong.Plugin{
Name: kong.String("request-termination"),
Config: kong.Configuration{
"status_code": 500,
"message": "no existing backendRef provided",
},
})
if strings.Contains(service.Service.Protocol, "http") || strings.Contains(service.Service.Protocol, "grpc") {

Check failure on line 82 in internal/dataplane/translator/translate_utils.go

View workflow job for this annotation

GitHub Actions / conformance-tests / expressions-router 

undefined: strings

Check failure on line 82 in internal/dataplane/translator/translate_utils.go

View workflow job for this annotation

GitHub Actions / conformance-tests / traditional-compatible-router 

undefined: strings

Check failure on line 82 in internal/dataplane/translator/translate_utils.go

View workflow job for this annotation

GitHub Actions / unit-tests / unit-tests 

undefined: strings

Check failure on line 82 in internal/dataplane/translator/translate_utils.go

View workflow job for this annotation

GitHub Actions / linters / lint 

undefined: strings (typecheck)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings package has to be imported for the build to pass.

service.Plugins = append(service.Plugins, kong.Plugin{
Name: kong.String("request-termination"),
Config: kong.Configuration{
"status_code": 500,
"message": "no existing backendRef provided",
},
})
}
}

return service, nil
Expand Down
Loading