Skip to content

Conversation

@whyoleg
Copy link
Collaborator

@whyoleg whyoleg commented Aug 18, 2025

No description provided.

@whyoleg whyoleg requested a review from adam-enko August 18, 2025 11:43
@whyoleg whyoleg self-assigned this Aug 18, 2025
@adam-enko
Copy link
Member

Is DGP not compatible with 2.2.0? I added it as a tested version in #4156. Or is there a mistake, and it's not actually tested?

@whyoleg
Copy link
Collaborator Author

whyoleg commented Aug 19, 2025

DGP is compatible with both 2.2.0 and 2.2.20.

This fix is needed for the specific case outlined in the issue mentioned in the code.
It was discovered in #4209: in KGP 2.2.20, androidVariant became a nullable and deprecated property, and so the compilation failed
This PR handles this just more gracefully.

@adam-enko adam-enko requested a review from Tapchicoma August 19, 2025 08:34
@adam-enko
Copy link
Member

adam-enko commented Aug 25, 2025

I've tried the code in this PR in a the android-it test project, and I got this error nm I copied the wrong code.

We've had another suggestion from the AGP team, so I'll try it out.

@whyoleg
Copy link
Collaborator Author

whyoleg commented Aug 28, 2025

replaced by #4231

@whyoleg whyoleg closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants