Skip to content

Fix compatibility with KGP 2.2.20 #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whyoleg wants to merge 1 commit into from
Closed

Fix compatibility with KGP 2.2.20 #4213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions dokka-runners/dokka-gradle-plugin/src/main/kotlin/adapters/KotlinAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,11 +453,18 @@ private class KotlinCompilationDetailsBuilder(
return when (this) {
is KotlinMetadataCompilation<*> -> true

// Use string-based comparison, not the actual classes, because AGP has deprecated and
// moved the Library/Application classes to a different package.
// Using strings is more widely compatible.
is KotlinJvmAndroidCompilation -> {
// Use string-based comparison, not the actual classes, because AGP has deprecated and
// moved the Library/Application classes to a different package.
// Using strings is more widely compatible.
val variantName = androidVariant::class.jvmName
// `runCatching` is used here, in case `androidVariant` will be removed in a future version of KGP.
val variantName = runCatching {
// https://youtrack.jetbrains.com/issue/KT-77023:
// `androidVariant` has `null` value in case of AGP/built-in Kotlin project.
@Suppress("DEPRECATION", "UNNECESSARY_NOT_NULL_ASSERTION")
androidVariant!!::class.jvmName
}.getOrNull() ?: return true // published by default

"LibraryVariant" in variantName || "ApplicationVariant" in variantName
}

Expand Down
Loading