Fix various typings #1324
Merged
Fix various typings #1324
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Oct 3, 2025
| bounds?: [ number, number, number, number ], | ||
| dimensions?: { [ key: string ]: any } | null, | ||
| url?: string | null, | ||
| capabilities?: WMTSCapabilitiesResult | null, |
There was a problem hiding this comment.
I'm thinking I'll probably be adjusting this API in a future change (related to #1309) to remove passing in "capabilities" and only providing literals so it removes the requirement to use the WMTSCapabilitiesLoader which can often take awhile to load. We can merge this for now but as an FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a duplicate of #1132 which was closed due to inactivity of OP (me 😅) and cannot be reopened for some reason.
Added changes wrt #1132 are
WMTSTilesOverlaytypes fixes. I made sure they are aligned withWMTSTilesPlugin(both usingWMTSImageSource), but please double check.Note that discussions on my changes were already underway in the original PR. It might be a good idea to check discussions there first.