Skip to content

Fix various typings #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 3, 2025
+21 −6
Merged

Fix various typings #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a95a3c9
Add TilesRenderer cameras in typings
xawill May 13, 2025
02a63a1
Add missing typings in Ellipsoid
xawill May 13, 2025
c7f14a5
Improve DebugTilesPlugin typings
xawill May 13, 2025
04d4edf
Fix WMTSTilesOverlay typings (aligned with WMTSTilesPlugin)
xawill Sep 18, 2025
213c650
Deprecate load in favor of loadAsync in LoaderBase typings
xawill Sep 25, 2025
66e48b2
WMTSTilesOverlay: url is optional
xawill Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/renderer/loaders/LoaderBase.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ export class LoaderBase<Result = any, ParseResult = Promise< Result >> {

fetchOptions: any;
workingPath: string;
/** @deprecated in favor of `loadAsync` */
load( url: string ): Promise< Result >;
loadAsync( url: string ): Promise< Result >;
resolveExternalURL( url: string ): string;
parse( buffer: ArrayBuffer ): ParseResult;

Expand Down
4 changes: 2 additions & 2 deletions src/three/plugins/DebugTilesPlugin.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Color } from 'three';
import { Color, Object3D } from 'three';
import { Tile } from '3d-tiles-renderer/core';

export enum ColorMode {}
Expand All @@ -24,7 +24,7 @@ export class DebugTilesPlugin {
maxDebugDepth?: number,
maxDebugDistance?: number,
maxDebugError?: number,
customColorCallback?: ( val: Tile, target: Color ) => void,
customColorCallback?: ( tile: Tile, object: Object3D ) => void,
unlit?: boolean,
enabled?: boolean,
} );
Expand Down
11 changes: 7 additions & 4 deletions src/three/plugins/images/ImageOverlayPlugin.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Color, Matrix4, WebGLRenderer } from 'three';
import { WMTSCapabilitiesResult, WMTSLayer, WMTSTileMatrixSet } from '../loaders/WMTSCapabilitiesLoader.js';

export class ImageOverlayPlugin {

Expand Down Expand Up @@ -82,10 +83,12 @@ export class WMSTilesOverlay extends ImageOverlay {
export class WMTSTilesOverlay extends ImageOverlay {

constructor( options: {
levels: number,
dimension: number,
url: string,
bounds?: [ number, number, number, number ],
dimensions?: { [ key: string ]: any } | null,
url?: string | null,
capabilities?: WMTSCapabilitiesResult | null,
Copy link
Contributor

@gkjohnson gkjohnson Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking I'll probably be adjusting this API in a future change (related to #1309) to remove passing in "capabilities" and only providing literals so it removes the requirement to use the WMTSCapabilitiesLoader which can often take awhile to load. We can merge this for now but as an FYI.

layer?: WMTSLayer | string | null,
tileMatrixSet?: WMTSTileMatrixSet | string | null,
style?: string,

color: number | Color,
opacity: number,
Expand Down
9 changes: 9 additions & 0 deletions src/three/renderer/math/Ellipsoid.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class Ellipsoid {
getCartographicToNormal( lat: number, lon: number, target: Vector3 ): Vector3;
getPositionToNormal( pos: Vector3, target: Vector3 ): Vector3;
getPositionToSurfacePoint( pos: Vector3, target: Vector3 ): Vector3;
getPositionElevation( pos: Vector3 ): number;

getEastNorthUpFrame( lat: number, lon: number, height: number, target: Matrix4 ): Matrix4;
getOrientedEastNorthUpFrame( lat: number, lon: number, height: number, az: number, el: number, roll: number, target: Matrix4 ): Matrix4;
Expand All @@ -42,4 +43,12 @@ export class Ellipsoid {
target: Matrix4, frame: Frames,
): Matrix4;

intersectRay( ray: Ray, target: Vector3 ): Vector3 | null;

calculateHorizonDistance( latitude: number, elevation: number ): number;
calculateEffectiveRadius( latitude: number ): number;

copy( source: Ellipsoid ): Ellipsoid;
clone(): Ellipsoid;

}
1 change: 1 addition & 0 deletions src/three/renderer/tiles/TilesRenderer.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export interface TilesRendererEventMap {
export class TilesRenderer<TEventMap extends TilesRendererEventMap = TilesRendererEventMap> extends TilesRendererBase implements EventDispatcher<TEventMap> {

ellipsoid: Ellipsoid;
cameras: Camera[];
autoDisableRendererCulling : boolean;
optimizeRaycast : boolean;

Expand Down
Loading