Skip to content

Add 'tiles-settled' event for robust detection of visual stability #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobias74 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add 'tiles-settled' event for robust detection of visual stability #1394

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f615c1a
introduce 'tiles-settled' event
tobias74 Dec 10, 2025
16dbb8b
fix formatting
tobias74 Dec 11, 2025
88aac9b
clarify comment on frame waiting logic
tobias74 Dec 11, 2025
2498959
Fix formatting and spacing in TilesRendererBase.js
tobias74 Dec 11, 2025
3ada3f9
Fix increment operator formatting in TilesRendererBase.js
tobias74 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/core/renderer/tiles/TilesRendererBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ export class TilesRendererBase {
visible: 0,
};
this.frameCount = 0;
this.framesSinceLastLoad = 0;

// callbacks
this._dispatchNeedsUpdateEvent = throttle( () => {
Expand Down Expand Up @@ -427,6 +428,24 @@ export class TilesRendererBase {

}

if ( ! this.isLoading && ! runningTasks ) {

this.framesSinceLastLoad ++;

// Wait for 2 frames to ensure the update loop has had a chance to queue new downloads.
if ( this.framesSinceLastLoad === 2 ) {

this.dispatchEvent( { type: 'tiles-settled' } );

}

} else {

this.framesSinceLastLoad = 0;

}


}

resetFailedTiles() {
Expand Down
Loading