Skip to content

Conversation

chzblych
Copy link
Collaborator

@chzblych chzblych commented Aug 7, 2025

Summary by CodeRabbit

  • Chores

    • Switched CUDA and framework image sources to an internal registry/mirror.
    • Added support for passing Triton image and tag into the Docker build process.
    • Updated build image references to use newer image build identifiers.
  • Tests

    • Added an additional auto-trigger condition for a DGX H100 test.
    • Simplified unit test setup by removing a redundant CUDA path override.

@chzblych chzblych requested review from a team as code owners August 7, 2025 16:48
Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

📝 Walkthrough

Walkthrough

Adds Triton build-arg passthrough to the Docker Makefile, switches CUDA base image references to nvcr.io, updates Jenkins to extract/rewrite base/triton image references to an internal mirror and pass them to make (with retry wrappers), updates a Jenkins test image, tweaks a test trigger condition, and removes a CUDA_HOME override in a unit test.

Changes

Cohort / File(s) Change Summary
Docker: Makefile updates
docker/Makefile
Add TRITON_IMAGE and TRITON_BASE_TAG variables (parsed from Dockerfile.multi) and include them conditionally as --build-arg in the build command; change several base-image references from nvidia/cudanvcr.io/nvidia/cuda.
Jenkins: image extraction & build flow
jenkins/BuildDockerImage.groovy
Extract BASE_IMAGE (from Dockerfile or Makefile for rockylinux8), rewrite nvcr.io/urm.nvidia.com/docker/ for BASE_IMAGE and TRITON_IMAGE, pass those as env vars to make, and replace direct sh pulls/builds with trtllm_utils.llmExecStepWithRetry calls.
Jenkins: L0 test image
jenkins/L0_Test.groovy
Update DLFW_IMAGE registry from nvcr.io/nvidia/pytorch:25.06-py3urm.nvidia.com/docker/nvidia/pytorch:25.06-py3.
Properties: image tag bumps
jenkins/current_image_tags.properties
Update four LLM-related image tags to new build identifier 202508110900-6715 (replacing 202508051130-6090).
Tests: integration trigger change
tests/integration/test_lists/test-db/l0_dgx_h100.yml
Add auto_trigger: others to the 4-GPU H100 Ubuntu Triton post_merge condition.
Tests: unit test cleanup
tests/unittest/test_pip_install.py
Remove code that set CUDA_HOME=/usr/local/cuda when CUDA_HOME was unset.

Sequence Diagram(s)

sequenceDiagram
    participant Jenkins as Jenkins Pipeline
    participant Utils as trtllm_utils.llmExecStepWithRetry
    participant Makefile as docker/Makefile
    participant Docker as Docker Build

    Jenkins->>Makefile: Read ARGs (BASE_IMAGE, TRITON_IMAGE, TRITON_BASE_TAG)
    Makefile-->>Jenkins: Return parsed values
    Jenkins->>Jenkins: Rewrite registry prefix nvcr.io/ -> urm.nvidia.com/docker/
    Jenkins->>Utils: Invoke pull/build with retries (image pulls, builds)
    Utils->>Docker: Execute docker build with env vars (BASE_IMAGE, TRITON_IMAGE, TRITON_BASE_TAG)
    Docker-->>Utils: Build result
    Utils-->>Jenkins: Return success/failure
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • niukuo
  • litaotju
  • nv-guomingz
  • kaiyux
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chzblych
Copy link
Collaborator Author

chzblych commented Aug 7, 2025

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14499 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14499 [ run ] completed with state FAILURE
/LLM/release-1.0/L0_MergeRequest_PR pipeline #18 (Partly Tested) completed with status: 'FAILURE'

@chzblych
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14686 [ run ] triggered by Bot

@chzblych
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14698 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14686 [ run ] completed with state ABORTED

@chzblych
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14704 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14698 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14704 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #45 (Partly Tested) completed with status: 'FAILURE'

chzblych and others added 4 commits August 11, 2025 14:28
@chzblych
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14757 [ run ] triggered by Bot

chzblych added a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 12, 2025
chzblych added a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 12, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 13, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 13, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
chzblych added a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 14, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
chzblych added a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 14, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 17, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 18, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 18, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 18, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 19, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 19, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 19, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan added a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 19, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 20, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 20, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 20, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 20, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Aug 21, 2025
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants