-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[None][infra] Avoid intermittent access broken to nvcr.io #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds Triton build-arg passthrough to the Docker Makefile, switches CUDA base image references to nvcr.io, updates Jenkins to extract/rewrite base/triton image references to an internal mirror and pass them to make (with retry wrappers), updates a Jenkins test image, tweaks a test trigger condition, and removes a CUDA_HOME override in a unit test. Changes
Sequence Diagram(s)sequenceDiagram
participant Jenkins as Jenkins Pipeline
participant Utils as trtllm_utils.llmExecStepWithRetry
participant Makefile as docker/Makefile
participant Docker as Docker Build
Jenkins->>Makefile: Read ARGs (BASE_IMAGE, TRITON_IMAGE, TRITON_BASE_TAG)
Makefile-->>Jenkins: Return parsed values
Jenkins->>Jenkins: Rewrite registry prefix nvcr.io/ -> urm.nvidia.com/docker/
Jenkins->>Utils: Invoke pull/build with retries (image pulls, builds)
Utils->>Docker: Execute docker build with env vars (BASE_IMAGE, TRITON_IMAGE, TRITON_BASE_TAG)
Docker-->>Utils: Build result
Utils-->>Jenkins: Return success/failure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/bot run --stage-list "Build-Docker-Images" |
PR_Github #14499 [ run ] triggered by Bot |
PR_Github #14499 [ run ] completed with state |
/bot run --stage-list "Build-Docker-Images" |
PR_Github #14686 [ run ] triggered by Bot |
/bot run --stage-list "Build-Docker-Images" |
PR_Github #14698 [ run ] triggered by Bot |
PR_Github #14686 [ run ] completed with state |
/bot run --stage-list "Build-Docker-Images" |
PR_Github #14704 [ run ] triggered by Bot |
PR_Github #14698 [ run ] completed with state |
PR_Github #14704 [ run ] completed with state |
Signed-off-by: Yanchao Lu <[email protected]>
Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]>
/bot run --skip-test |
PR_Github #14757 [ run ] triggered by Bot |
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Yanchao Lu <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…DIA#6715) Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Signed-off-by: Yanchao Lu <[email protected]> Co-authored-by: Zhanrui Sun <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
Summary by CodeRabbit
Chores
Tests