Skip to content

Enable Webhook Warning messages, add Gateway API integration and simply Ingress integration #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Enable Webhook Warning messages, add Gateway API integration and simply Ingress integration #643

wants to merge 7 commits into from

Conversation

shengnuo
Copy link
Collaborator

@shengnuo shengnuo commented Aug 29, 2025 •
edited
Loading

This PR introduces a new field under .spec.router for NIMService and NeMo Microservices, for integrating with Ingress or Gateway API.

The created routing object will have the hostname in the format <.metadata.name>.<.spec.router.hostDomainName>

Gateway API

Sample router for Gateway API integration

  router:
    gateway:
      namespace: nemo
      name: istio-gateway
    hostDomainName: foobar.com

Only HTTPRoutes is supported from Gateway API.
GRPCRoutes is pending.

Ingress

Sample router for Ingress integration

router:
  ingressClass: nginx
  hostDomainName: foobar.com

Deprecation

NIMService.spec.expose.ingress will be deprecated. The field is present, it will not be used to create Ingress objects, and a warning message from webhook will be display.

The deprecated fields will remain for sometimes for backward compatibility.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

This was referenced Aug 29, 2025
Closed
Closed
@shengnuo shengnuo force-pushed the simplify-route-2 branch 2 times, most recently from b832087 to bca6f48 Compare September 5, 2025 19:57
@shengnuo
Update vendor
7480088 
Signed-off-by: Sheng Lin <[email protected]>
@shengnuo
Simply Ingress in NIMService and NeMo microservice CRs and let NIM Op…
7f13558 
…erator create HTTPRoute objects from Gateway API

Signed-off-by: Sheng Lin <[email protected]>
@shengnuo
Fix existing linter issue
d6d368a 
Signed-off-by: Sheng Lin <[email protected]>
@shengnuo shengnuo marked this pull request as ready for review September 5, 2025 20:02
@shengnuo shengnuo changed the title Add Gateway API integration and simply Ingress integration Enable Webhook Warning messages, add Gateway API integration and simply Ingress integration Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

@slu2011 slu2011 Awaiting requested review from slu2011 slu2011 is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

@varunrsekar varunrsekar Awaiting requested review from varunrsekar varunrsekar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shengnuo