Skip to content

3.2 consistent use of "case-(in)sensitive" #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2025
Merged

3.2 consistent use of "case-(in)sensitive" #4942

merged 3 commits into from
Sep 16, 2025

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Sep 12, 2025 •
edited
Loading

We used both "case-sensitive" and "case sensitive", switching to the variant with dashes, also for "case-insensitive".

  • no schema changes are needed for this pull request

@ralfhandl
Consistent dashing for case sensitive
319871b 
We used both flavors, with and without dash.
@ralfhandl ralfhandl requested review from a team as code owners September 12, 2025 12:19
@ralfhandl ralfhandl changed the base branch from main to v3.2-dev September 12, 2025 12:19
@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Sep 12, 2025
@ralfhandl ralfhandl added this to the v3.2.0 milestone Sep 12, 2025
lornajane
lornajane previously approved these changes Sep 12, 2025
View reviewed changes
@ralfhandl ralfhandl requested a review from a team September 12, 2025 19:10
@ralfhandl ralfhandl enabled auto-merge September 12, 2025 19:10
@ralfhandl ralfhandl disabled auto-merge September 12, 2025 20:15
earth2marsh
earth2marsh requested changes Sep 14, 2025
View reviewed changes
@ralfhandl ralfhandl changed the title 3.2 consistent use of "case sensitive" 3.2 consistent use of "case-(in)sensitive" Sep 15, 2025
lornajane
lornajane previously approved these changes Sep 15, 2025
View reviewed changes
earth2marsh
earth2marsh reviewed Sep 15, 2025
View reviewed changes
earth2marsh
earth2marsh previously approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@earth2marsh earth2marsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the hyphenation of the noun form, but otherwise this LGTM

@ralfhandl ralfhandl dismissed stale reviews from earth2marsh and lornajane via b5c43e5 September 15, 2025 19:25
earth2marsh
earth2marsh approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@earth2marsh earth2marsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY!

@ralfhandl ralfhandl requested a review from a team September 15, 2025 21:43
mikekistler
mikekistler approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl merged commit bea55aa into OAI:v3.2-dev Sep 16, 2025
2 checks passed
@ralfhandl ralfhandl deleted the 3.2-case-sensitive branch September 16, 2025 10:54
@ralfhandl ralfhandl mentioned this pull request Sep 16, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earth2marsh earth2marsh earth2marsh approved these changes

@mikekistler mikekistler mikekistler approved these changes

@lornajane lornajane Awaiting requested review from lornajane

Assignees
No one assigned
Labels
editorial Wording and stylistic issues
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ralfhandl @earth2marsh @lornajane @mikekistler