[wip] Asymmetry #519
Draft
[wip] Asymmetry #519
+8,322
−4,048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
louisgreiner
force-pushed
the
lgr/asymmetry
branch
from
a1706bc to
0784c94
Compare
louisgreiner
force-pushed
the
lgr/asymmetry
branch
15 times, most recently
from
fb51a6f to
6293d17
Compare
louisgreiner
force-pushed
the
lgr/asymmetry
branch
4 times, most recently
from
d84931e to
ae65fdb
Compare
louisgreiner
force-pushed
the
lgr/asymmetry
branch
6 times, most recently
from
01324b1 to
43e67a3
Compare
…y on trainrun-tab component Enables to reset the symmetry on the whole trainrun at once. Signed-off-by: Louis Greiner <[email protected]>
…y on perlenkette component Signed-off-by: Louis Greiner <[email protected]>
…symmetry on perlenkette-section component Also includes a refactor (sorry for the diff) because this component was impossible to work with otherwise. Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
…equal (on/off) Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/asymmetry
branch
from
ee87729 to
7455e0c
Compare
Had to nuke a lot a existing code to make non-symmetry fit in it. Created a BackwardIterator for that also. Non-stop fully symmetrical trainruns work. Non-stop asymetrical trainruns are not working yet. Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/asymmetry
branch
from
7455e0c to
4338dde
Compare
Did not test with asymmetric trainruns, only fixed for regular trainruns. Travel time update looks still broken too (but wasn't it already?). Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
…are not coherent due to asymmetry Removed the source->target legacy check. This component should be refactored once more, it's still hard to read. Signed-off-by: Louis Greiner <[email protected]>
…times become non symmetrical Signed-off-by: Louis Greiner <[email protected]>
…tions chain (non-stop case) Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
This can be easily refactored. Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/asymmetry
branch
4 times, most recently
from
b489bda to
2c03b21
Compare
…unSections Hell yeah. Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/asymmetry
branch
from
2c03b21 to
67fa2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still work in progress
Can be review until commit: asymmetry: add symmetry TrainrunSection toggle + enable to reset the symmetry on perlenkette-section component
Missing features:
Some bugs (shaky features) to fix:
Ref #418
For reviewing: https://sncf.sharepoint.com/:p:/r/sites/OSRD644GrpO365/_layouts/15/Doc.aspx?sourcedoc=%7B68C024EF-2C05-4B4D-86C1-ED205F966F2F%7D&file=Cas%20modifs%20temps%20NGE.pptx&action=edit&mobileredirect=true