[wip] full asymmetry #501
Closed
[wip] full asymmetry #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit intends to ensure that the trainruns are all [source] → [target] consistent. Before this commit, we could have trainruns like [[source] → [target][target] → [source][target] → [target][source]...], which is a pain to work with because the trainrunSections are not ordered, so the order has to be deducted from the [source] → [target] chain. It is an enabler for one-way trainruns, since we need to have ordered trainrunSections. The current implementation has been stolen to @emersion, and is not compatible with actual cyclic trainruns. It needs to be rethought. Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
…nrunSection dialog Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
…tement for one-way trains
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
2 times, most recently
from
a4b46ee to
59fea42
Compare
--------- Signed-off-by: Louis Greiner <[email protected]> Co-authored-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
5 times, most recently
from
fe626b0 to
f096c3f
Compare
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
2 times, most recently
from
74f5648 to
7c2d429
Compare
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
4 times, most recently
from
ea9247b to
8b1a9c6
Compare
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
5 times, most recently
from
1fdf2d9 to
2b94677
Compare
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
from
2b94677 to
56f2d3d
Compare
… + update trainrunSection dialog + introduce SymmetrySelectionDialog Signed-off-by: Louis Greiner <[email protected]>
…ymmetric Trainruns Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/full-asymmetry
branch
from
56f2d3d to
cc2176f
Compare
24 tasks
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
sba/enable-one-way-trainrun
branch
3 times, most recently
from
d184532 to
b5bfed0
Compare
|
Closing this PR since the rebase after the one-way PR + Prettier made it impossible to recover. Opened a new PR with a fresh new branch: #519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for review purpose
Ref #418